On Thu, 23 Apr 2026 20:59:06 GMT, Alexey Semenyuk <[email protected]> wrote:
> JPackageStringBundle: move FormattedMessage class to the top level, rename it > to CannedMessageFormat, and make it public. > The CannedMessageFormat class can be used to create a format string bound to > the format string arguments, where the format string is loaded from a string > bundle or picked from any other source > > Additionally: > - JPackageCommand: support running jpackage with modified environment > variables > - LinuxHelper: expose `getReleaseSuffix()` > - JPackageCommand: add `fullVersion()` based on > `LinuxHelper.getReleaseSuffix()` > > --------- > - [x] I confirm that I make this contribution in accordance with the [OpenJDK > Interim AI Policy](https://openjdk.org/legal/ai). test/jdk/tools/jpackage/helpers-test/jdk/jpackage/test/CannedFormattedStringTest.java line 95: > 93: assertEquals(a, b); > 94: assertEquals(a.getValue(), b.getValue()); > 95: assertNotEquals(a, c); If this is supposed to test the `CannedFormattedString#equals` implementation, then maybe this should not use `assertEquals` and `assertNotEquals` but instead explicitly invoke `equals`, e.g. `assertTrue(a.equals(b))`. See https://docs.junit.org/6.0.3/api/org.junit.jupiter.api/org/junit/jupiter/api/Assertions.html#object-equality-heading (This is only a suggestion, I am not an OpenJDK member.) ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/30906#discussion_r3134199705
