On Fri, 24 Apr 2026 23:24:47 GMT, Alexander Matveev <[email protected]>
wrote:
>> Alexey Semenyuk has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix review findings
>
> test/jdk/tools/jpackage/helpers-test/jdk/jpackage/test/CannedFormattedStringTest.java
> line 100:
>
>> 98: assertEquals("Bye Duke!", c.getValue());
>> 99:
>> 100: assertEquals("Repeated messagge: Hello Duke! Hello Duke!",
>> a.addPrefix("Repeated message: {0} {0}").getValue());
>
> You still have `messagge` as first argument. Only second one is changed, so
> test will fail.
Also, `messageFormatFormatString` is still present in some places.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/30906#discussion_r3140765581
