On Fri, 24 Apr 2026 23:26:02 GMT, Alexey Semenyuk <[email protected]> wrote:
>> JPackageStringBundle: move FormattedMessage class to the top level, rename >> it to CannedMessageFormat, and make it public. >> The CannedMessageFormat class can be used to create a format string bound to >> the format string arguments, where the format string is loaded from a string >> bundle or picked from any other source >> >> Additionally: >> - JPackageCommand: support running jpackage with modified environment >> variables >> - LinuxHelper: expose `getReleaseSuffix()` >> - JPackageCommand: add `fullVersion()` based on >> `LinuxHelper.getReleaseSuffix()` >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Alexey Semenyuk has updated the pull request incrementally with one > additional commit since the last revision: > > Fix review findings test/jdk/tools/jpackage/helpers-test/jdk/jpackage/test/CannedFormattedStringTest.java line 100: > 98: assertEquals("Bye Duke!", c.getValue()); > 99: > 100: assertEquals("Repeated messagge: Hello Duke! Hello Duke!", > a.addPrefix("Repeated message: {0} {0}").getValue()); You still have `messagge` as first argument. Only second one is changed, so test will fail. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/30906#discussion_r3140761367
