On Sun, 16 Aug 2026 20:58:38 GMT, Marcono1234 <[email protected]> wrote:
>> Naoto Sato has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 726 commits: >> >> - Merge remote-tracking branch 'jdk-sandbox/json' into >> JDK-8381976-Implementation-for-Simple-JSON-API >> - Address comment regarding asDouble wording in class spec >> - Reflects Alan's comments >> - Merge branch 'master' into JDK-8381976-Implementation-for-Simple-JSON-API >> - Merge remote-tracking branch 'jdk-sandbox/json' into >> JDK-8381976-Implementation-for-Simple-JSON-API >> - Removed unused imports >> - Removed unnecessary qualifiers >> - Merge remote-tracking branch 'jdk-sandbox/json' into >> JDK-8381976-Implementation-for-Simple-JSON-API >> - Merge branch 'toDisplayString' into json >> - wording >> - ... and 716 more: https://git.openjdk.org/jdk/compare/16bf2730...76272098 > > src/jdk.incubator.json/share/classes/jdk/incubator/json/JsonString.java line > 69: > >> 67: return new JsonStringImpl(escaped.toCharArray(), 0, >> escaped.length(), >> 68: escaped.length() != src.length() + 2); >> 69: } > > Would it make sense to optimize this, e.g. by having a `JsonStringImpl` > constructor which takes the unescaped value? > > Current behavior might not be ideal that `JsonString.of(...).asString()` can > involve escaping and unescaping. `equals` would be much harder to implement correctly if we do not escape upon construction. > src/jdk.incubator.json/share/classes/jdk/incubator/json/impl/JsonBooleanImpl.java > line 2: > >> 1: /* >> 2: * Copyright (c) 2025, Oracle and/or its affiliates. All rights reserved. > > 2026 missing? > > Same also for `JsonNullImpl.java` and `JsonNull.java` The JSON code has been in development in the sandbox; I don't think we add the year of actual commit here, we just use the date for the last update when it was in its dedicated development branch. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/32282#discussion_r3793155397 PR Review Comment: https://git.openjdk.org/jdk/pull/32282#discussion_r3793157870
