On Sun, 16 Aug 2026 21:17:04 GMT, Marcono1234 <[email protected]> wrote:
>> Naoto Sato has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 726 commits: >> >> - Merge remote-tracking branch 'jdk-sandbox/json' into >> JDK-8381976-Implementation-for-Simple-JSON-API >> - Address comment regarding asDouble wording in class spec >> - Reflects Alan's comments >> - Merge branch 'master' into JDK-8381976-Implementation-for-Simple-JSON-API >> - Merge remote-tracking branch 'jdk-sandbox/json' into >> JDK-8381976-Implementation-for-Simple-JSON-API >> - Removed unused imports >> - Removed unnecessary qualifiers >> - Merge remote-tracking branch 'jdk-sandbox/json' into >> JDK-8381976-Implementation-for-Simple-JSON-API >> - Merge branch 'toDisplayString' into json >> - wording >> - ... and 716 more: https://git.openjdk.org/jdk/compare/16bf2730...76272098 > > src/jdk.incubator.json/share/classes/jdk/incubator/json/impl/JsonParser.java > line 137: > >> 135: if (members.putIfAbsent(name, parseValue()) != null) { >> 136: throw failure(nameStart, nameLine, nameLineStart, >> 137: "The duplicate member name: \"%s\" was already >> parsed".formatted(name), startO, true); > > Message sounds maybe a bit weird, should this either omit the leading "The > ..." or omit the colon ":"? > - "Duplicate member name: ..." > - "The duplicate member name ..." Let's go with the former, since it is more consistent with `JsonObject.of(Map)`. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/32282#discussion_r3797826054
