On Sun, 16 Aug 2026 19:53:59 GMT, Marcono1234 <[email protected]> wrote:
>> Naoto Sato has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 726 commits: >> >> - Merge remote-tracking branch 'jdk-sandbox/json' into >> JDK-8381976-Implementation-for-Simple-JSON-API >> - Address comment regarding asDouble wording in class spec >> - Reflects Alan's comments >> - Merge branch 'master' into JDK-8381976-Implementation-for-Simple-JSON-API >> - Merge remote-tracking branch 'jdk-sandbox/json' into >> JDK-8381976-Implementation-for-Simple-JSON-API >> - Removed unused imports >> - Removed unnecessary qualifiers >> - Merge remote-tracking branch 'jdk-sandbox/json' into >> JDK-8381976-Implementation-for-Simple-JSON-API >> - Merge branch 'toDisplayString' into json >> - wording >> - ... and 716 more: https://git.openjdk.org/jdk/compare/16bf2730...76272098 > > src/jdk.incubator.json/share/classes/jdk/incubator/json/impl/JsonArrayImpl.java > line 67: > >> 65: throw Utils.composeError(this, >> 66: "JsonArray index %d out of bounds for length %d." >> 67: .formatted(index, theValues.size())); > > Should this specify `Locale.ENGLISH`? Otherwise depending on the OS default > locale you end up with an English exception message containing non-English > numerals, which might make troubleshooting a bit cumbersome. > > (Not sure if other parts of the JDK code account for this though.) That's a valid point. Will fix it. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/32282#discussion_r3797404835
