On Wed, 19 Aug 2026 11:35:27 GMT, Jaikiran Pai <[email protected]> wrote:
> Can I please get a review of this change which cleans up the `libzip` ZIP > utility library in the JDK? > > As noted in https://bugs.openjdk.org/browse/JDK-8390647, over time, this > library has accumulated some functions which are no longer used. The commit > in this PR removes those unused functions and moves some internal functions > in to the implementation (`.c` file) instead of having it in the header file. > Some macros too have been moved into the implementation. > > No new test has been introduced but existing tests in tier1, tier2 and tier3 > continue to pass with this change. Once the PR is reviewed, I'll run higher > tiers too before integrating. > > --------- > - [x] I confirm that I make this contribution in accordance with the [OpenJDK > Interim AI Policy](https://openjdk.org/legal/ai). I think overall this is ok, not sure I see a need to move the macros from zip_util.h src/java.base/share/native/libzip/zip_util.c line 176: > 174: #define ZIP_ENDCHAIN ((jint)-1) > 175: > 176: Not sure I see a real need to move the macros out of zip_util.h given the file itself is not going away ------------- PR Review: https://git.openjdk.org/jdk/pull/32448#pullrequestreview-4973990724 PR Review Comment: https://git.openjdk.org/jdk/pull/32448#discussion_r3814480541
