On Thu, 20 Aug 2026 16:38:57 GMT, Alan Bateman <[email protected]> wrote:
>> Jaikiran Pai has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains seven additional >> commits since the last revision: >> >> - move back the ZIP_ENDCHAIN macro into header file >> - merge latest from master branch >> - Revert "move macros out of header file" >> >> This reverts commit 1a0d87f8abb1af4f1c8613a43fce32f0e235e9d3. >> - Revert "move STORED and DEFLATED macros out of the header file" >> >> This reverts commit 5060445db8177bf9403229d02c55c617a04d7b00. >> - move STORED and DEFLATED macros out of the header file >> - move macros out of header file >> - move some functions as internal details > > src/java.base/share/native/libzip/zip_util.c line 808: > >> 806: zip->refs++; >> 807: break; >> 808: } > > If the second/third/fourth expressions were indented a bit more then it would > be easier to see where the condition ends. Thanks for spotting this, I hadn't noticed it. I have fixed the indentation now. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/32448#discussion_r3826661402
