> Can I please get a review of this change which cleans up the `libzip` ZIP > utility library in the JDK? > > As noted in https://bugs.openjdk.org/browse/JDK-8390647, over time, this > library has accumulated some functions which are no longer used. The commit > in this PR removes those unused functions and moves some internal functions > in to the implementation (`.c` file) instead of having it in the header file. > Some macros too have been moved into the implementation. > > No new test has been introduced but existing tests in tier1, tier2 and tier3 > continue to pass with this change. Once the PR is reviewed, I'll run higher > tiers too before integrating. > > --------- > - [x] I confirm that I make this contribution in accordance with the [OpenJDK > Interim AI Policy](https://openjdk.org/legal/ai).
Jaikiran Pai has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains seven additional commits since the last revision: - move back the ZIP_ENDCHAIN macro into header file - merge latest from master branch - Revert "move macros out of header file" This reverts commit 1a0d87f8abb1af4f1c8613a43fce32f0e235e9d3. - Revert "move STORED and DEFLATED macros out of the header file" This reverts commit 5060445db8177bf9403229d02c55c617a04d7b00. - move STORED and DEFLATED macros out of the header file - move macros out of header file - move some functions as internal details ------------- Changes: - all: https://git.openjdk.org/jdk/pull/32448/files - new: https://git.openjdk.org/jdk/pull/32448/files/1a0d87f8..1a7bb069 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=32448&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=32448&range=00-01 Stats: 1766 lines in 53 files changed: 1266 ins; 319 del; 181 mod Patch: https://git.openjdk.org/jdk/pull/32448.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/32448/head:pull/32448 PR: https://git.openjdk.org/jdk/pull/32448
