On Fri, 21 Aug 2026 01:49:00 GMT, Jaikiran Pai <[email protected]> wrote:
>> Can I please get a review of this change which cleans up the `libzip` ZIP >> utility library in the JDK? >> >> As noted in https://bugs.openjdk.org/browse/JDK-8390647, over time, this >> library has accumulated some functions which are no longer used. The commit >> in this PR removes those unused functions and moves some internal functions >> in to the implementation (`.c` file) instead of having it in the header >> file. Some macros too have been moved into the implementation. >> >> No new test has been introduced but existing tests in tier1, tier2 and tier3 >> continue to pass with this change. Once the PR is reviewed, I'll run higher >> tiers too before integrating. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Jaikiran Pai has updated the pull request incrementally with one additional > commit since the last revision: > > fix indentation Thank you Alan and Lance for the reviews. I'll need a re-review for the latest indentation fix related update. ------------- PR Comment: https://git.openjdk.org/jdk/pull/32448#issuecomment-5391527718
