On Fri, 28 Aug 2026 16:13:37 GMT, Markus KARG <[email protected]> wrote:

>> This Pull Request provides an implementation for 
>> [JDK-8389573](https://bugs.openjdk.org/browse/JDK-8389573): 
>> 'InputStreamReader.readAllAsString() should override the generic Reader 
>> default implementation to avoid unnecessary buffer copies'.
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Markus KARG has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Removed readCalled=true from read() and implRead()

test/jdk/java/io/Reader/ReadAll.java line 199:

> 197:         assertEquals(stringExpected.substring(n), string);
> 198: 
> 199:         // InputStreamReader implementation: Called directly after 
> construction (Fast Path)

I haven't focused on the test yet, but just a drive by comment for now - I 
think we should remove the mentions of fast/slow path from this test update.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/32264#discussion_r3886872295

Reply via email to