Re: DateTime::TimeZone 0.01_00

[John Peacock]

Dave Rolsky wrote:

Please try them out and let me know what you think, what bugs you find,
etc.

I don't think it is really necessary to manify all of the various TimeZone/*/*.pm data files; there is no real point in doing so (since there is no substantive information for the user contained within). I view ExtUtils::MakeMaker's obsessive creation of man files for every .PM file to be an undesireable feature, just shy of an outright bug.

I would suggest something like the attached which will manify only the files with some content. perldoc will still be able to display the POD for the data files, if desired.

John

p.s. You also need to apply the following minor patch

--- t/01load.t.orig 2003-02-04 22:49:35.000000000 -0500
+++ t/01load.t 2003-02-04 22:49:48.000000000 -0500
@@ -14,7 +14,4 @@ BEGIN

plan tests => 1;

-BEGIN
-{
- use_ok('DateTime::TimeZone');
-}
+use_ok('DateTime::TimeZone');

since you cannot have the use_ok() wrapped in a BEGIN (since Test::More won't be loaded yet).

--
John Peacock
Director of Information Research and Technology
Rowman & Littlefield Publishing Group
4720 Boston Way
Lanham, MD 20706
301-459-3366 x.5010
fax 301-429-5747

--- Makefile.PL.orig    2003-02-04 22:36:40.000000000 -0500
+++ Makefile.PL 2003-02-04 22:38:43.000000000 -0500
@@ -6,6 +6,16 @@ WriteMakefile( NAME         => 'DateTime
                VERSION_FROM => 'lib/DateTime/TimeZone.pm',
                AUTHOR       => 'Dave Rolsky <[EMAIL PROTECTED]>',
                ABSTRACT     => '',
+              MAN3PODS     => {
+               'lib/DateTime/TimeZone.pm'
+                 => '$(INST_MAN3DIR)/DateTime::TimeZone.$(MAN3EXT)',
+               'lib/DateTime/TimeZoneCatalog.pm'
+                 => '$(INST_MAN3DIR)/DateTime::TimeZoneCatalog.$(MAN3EXT)',
+               'lib/DateTime/TimeZone/OffsetOnly.pm'
+                 => '$(INST_MAN3DIR)/DateTime::TimeZone::OffsetOnly.$(MAN3EXT)',
+               'lib/DateTime/TimeZone/UTC.pm'
+                 => '$(INST_MAN3DIR)/DateTime::TimeZone::UTC.$(MAN3EXT)',
+              },
                PREREQ_PM => { 'Tree::RedBlack' => 0,
                               'Params::Validate' => 0,
                               'Class::Singleton' => 1.03,