On 13/03/17 14:45, Byron Jones wrote:
David Burns wrote:
We should try mitigate the security problem and fix our nit problem
instead of bashing that we can't handle re-reviews because of nits.
one way tooling could help here is to allow the reviewer to make minor
changes to the patch before it lands.
ie. "r+, fix typo in comment before landing" would become "r+, i fixed
the comment typo"
Assuming you mean "and land without further review", I don't see how
this has different security properties from r+-with-nits in the —
reasonably common — case that the patch author is at least as trusted as
the reviewer (e.g. both L3 today).
I do think that tooling to support multiple authors collaborating on a
single branch is a good thing independent of the changes discussed in
this thread.
_______________________________________________
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform
