👍💟 On Sun, Jan 5, 2020 at 4:38 AM Kaxil Naik <[email protected]> wrote:
> I have created a Github app using Probot: > https://github.com/kaxil/boring-cyborg. > > This is integrated with Airflow and we now have auto-labeling enabled based > on filepaths of the changes files in the PR. > > We can add more integrations iteratively in the "boring-cyborg" and > automate other boring chores in Airflow. > > @Max - Do you want me to raise a PR with superset to integrate this Github > App or just copy/paste the code to the Superset bot? > > Regards, > Kaxil > > Regards, > Kaxil > > On Sat, Jan 4, 2020 at 10:53 AM Jarek Potiuk <[email protected]> > wrote: > > > Those both are cool. Love them :). > > > > Why not use the periodic labeler workaround? It seems to do the trick and > > uses the same configuration and does not seem to have any negative side > > effects. > > > > I think auto-labelling our PRs would be a great step (together with > working > > stale bot) towards making more organised process about triaging/handling > > PRs. > > > > J. > > > > > > On Sat, Jan 4, 2020 at 3:28 AM Kaxil Naik <[email protected]> wrote: > > > > > On digging further I found out that it is an open BUG on both the > Github > > > actions: > > > > > > Bug: https://github.com/actions/labeler/issues/12 or > > > https://github.com/actions/first-interaction/issues/10 > > > > > > > > > *Details*: > > > > > > Quoting the Author: > > > ---- > > > Workflows are run in the context "of the repository". But when any > > workflow > > > is run because a pull request triggered it, then the token is > downgraded > > to > > > a read-only token. > > > It's not "the fork's token", it's still the repository's token, it's > just > > > read-only. > > > This is intentional. It's so that somebody can't open a pull request > that > > > gives them a token that they could use to write to your repository. > > > ---- > > > > > > They are working towards fixing this but I am removing the integrations > > > meanwhile. There is a workaround - > > > https://github.com/actions/labeler/issues/12#issuecomment-555746868 > but > > I > > > don't want to use it until it is resolved in the original repo. > > > > > > > > > Regards, > > > Kaxil > > > > > > > > > > > > > > > On Sat, Jan 4, 2020 at 1:07 AM Kaxil Naik <[email protected]> wrote: > > > > > > > I think I was wrong. We still need permission from INFRA to enable > the > > > > GITHUB_TOKEN, I have raised an ISSUE with INFRA team: > > > > https://issues.apache.org/jira/browse/INFRA-19657 > > > > > > > > Apache Spark recently added a Github Action for Stable > > > > <https://github.com/apache/spark/pull/26877>, hence I thought we > won't > > > > require any perms from INFRA team. Although it didn't threw them > error > > as > > > > the stale bot didn't actually need to take any action yet. Similarly > > the > > > 2 > > > > Github actions seems to pass all time in Airflow repo except when > they > > > need > > > > to actually add labels. > > > > > > > > Hopefully, the INFRA team will enable this soon as we just read > > > permission > > > > and write-on labels. > > > > > > > > Regards, > > > > Kaxil > > > > > > > > On Fri, Jan 3, 2020 at 11:07 PM Kaxil Naik <[email protected]> > > wrote: > > > > > > > >> I tried some Github actions today and fell in love. We don't even > need > > > to > > > >> ask for approval from INFRA team. > > > >> > > > >> I have raised 2 PRs: > > > >> > > > >> - https://github.com/apache/airflow/pull/7032 - Add Labels on > PRs > > > >> based on file/dir > > > >> - https://github.com/apache/airflow/pull/7031 - Welcome First > time > > > >> contributors > > > >> > > > >> to integrate this in Airflow too. I have tested them on my other > repo > > > and > > > >> works like a charm. > > > >> > > > >> Regards, > > > >> Kaxil > > > >> > > > >> On Fri, Jan 3, 2020 at 2:38 PM Kaxil Naik <[email protected]> > > wrote: > > > >> > > > >>> Yeah the mention-bot was archived and is no longer maintained. > > > >>> > > > >>> On Fri, Jan 3, 2020 at 2:33 PM Tomasz Urbaszek < > > > >>> [email protected]> wrote: > > > >>> > > > >>>> Hi all, > > > >>>> > > > >>>> I just discovered that some time ago we already used "mention-bot" > > > that > > > >>>> suggests > > > >>>> potential reviewers based on history of changed files: > > > >>>> > https://github.com/apache/airflow/pull/2558#issuecomment-326686092 > > > >>>> > > > >>>> T. > > > >>>> > > > >>>> > > > >>>> On Thu, Jan 2, 2020 at 2:33 AM Jarek Potiuk < > > [email protected] > > > > > > > >>>> wrote: > > > >>>> > > > >>>> > On Wed, Jan 1, 2020 at 11:47 PM Jarek Potiuk < > > > >>>> [email protected]> > > > >>>> > wrote: > > > >>>> > > > > >>>> > > One thing I realized after using the 4 Probot Integrations is > > that > > > >>>> some > > > >>>> > of > > > >>>> > >> the Probot apps are not actively maintained and might even be > > > >>>> broken. > > > >>>> > >> > > > >>>> > > > > > >>>> > Yeah. Even if limited my search to only the "featured ones" > seems > > > >>>> like not > > > >>>> > all of them are good. > > > >>>> > Luckily it's easy to enable/disable them when needed. > > > >>>> > > > > >>>> > However I think maybe the right approach is "try before buy". > > > >>>> > I will try some of them on our internal fork where we work and > > then > > > >>>> once I > > > >>>> > get > > > >>>> > some hands-on we can decide if it makes sense to use them or > not. > > > >>>> It's a > > > >>>> > bit of a hassle that > > > >>>> > we have to open an issue to infra to get those added/removed so > > It's > > > >>>> easier > > > >>>> > to try them on our repo. > > > >>>> > I already added the "pull" one to synchronize our fork (pretty > > > useful > > > >>>> but > > > >>>> > spammy). > > > >>>> > > > > >>>> > > > > >>>> > - https://probot.github.io/apps/welcome/ : This one has this > > > >>>> > >> <https://github.com/behaviorbot/welcome/issues/12> > particular > > > >>>> issue > > > >>>> > open > > > >>>> > >> that might not make the experience pleasant for contributors. > > > >>>> > >> > > > >>>> > > OK. That's no go :). > > > >>>> > > > > >>>> > > > > >>>> > > - https://github.com/mithro/autolabeler: Need to test if it > is > > > >>>> working > > > >>>> > as > > > >>>> > >> it looks a bit outdated (and not actively maintained - no > > replies > > > >>>> on > > > >>>> > >> issues > > > >>>> > > > > > >>>> > > > > > >>>> > I will try. But I'd love to get those features in Max's probot > > > >>>> instead in > > > >>>> > this case (I know it was on his list). > > > >>>> > > > > >>>> > > > > >>>> > > - https://probot.github.io/apps/pr-triage/ : Might be good to > > > have > > > >>>> but > > > >>>> > >> this > > > >>>> > >> issue <https://github.com/pr-triage/app/issues/181> might > bite > > > us > > > >>>> too. > > > >>>> > >> Not > > > >>>> > >> a major problem but just something to note. > > > >>>> > >> > > > >>>> > > > > > >>>> > Right. I think we might soon get down to a manageable number of > > > >>>> issues as > > > >>>> > the stalebot does it's job finally. > > > >>>> > So maybe we won't need that one. > > > >>>> > > > > >>>> > > > > >>>> > > - https://probot.github.io/apps/tests-checker/ : I liked this > > one > > > >>>> > >> > > > >>>> > > > > > >>>> > I like it too but I will try it :). I am afraid it might be a > bit > > > >>>> offensive > > > >>>> > at times though. > > > >>>> > > > > >>>> > > > > >>>> > > - https://probot.github.io/apps/reminders/ : Again might be > > > >>>> outdated but > > > >>>> > >> would need some testing to see if it actually works. > > > >>>> > > > > > >>>> > > > > > >>>> > It's just a nuance - not high priority at all. > > > >>>> > > > > >>>> > > > > >>>> > > - https://github.com/z0al/dep : I liked this one too but it > > > >>>> currently > > > >>>> > only > > > >>>> > >> matches on "#PR_NUMBER". Open Issue < > > > >>>> > >> https://github.com/z0al/dep/issues/18> so > > > >>>> > >> would want to hear opinions from others. > > > >>>> > > > > > >>>> > > > > > >>>> > I really love that one. It very well reflects the pattern we > have > > > for > > > >>>> some > > > >>>> > complex changes. which require multiple commits. > > > >>>> > And it's very good for it to depend on #PR number. It's super > easy > > > >>>> when you > > > >>>> > type "Depends on #<START_TYPING_HERE>" - > > > >>>> > you can start typing JIRA_ID or part of description and it will > > > >>>> auto-show > > > >>>> > the list of matching PRs. We do not have multiple repos > > > >>>> > so the issue https://github.com/z0al/dep/issues/18 is not > really > > > >>>> relevant > > > >>>> > in our case. > > > >>>> > > > > >>>> > And if we have it working we will not need to add this funny > > > "Depends > > > >>>> on > > > >>>> > [AIRFLOW-NNNN]". We will see immediately when PR is not > mergeable > > > >>>> > because it depends on other PRs without these extra > descriptions. > > > >>>> > > > > >>>> > > > > >>>> > >> @Max - I like your idea and maybe long term it might make > more > > > >>>> sense. > > > >>>> > >> Happy > > > >>>> > >> to help in the effort so that we can make it more *general*. > > > >>>> > >> > > > >>>> > > > > > >>>> > Max - happy to contribute to the SuperSet probot as well. It > would > > > be > > > >>>> great > > > >>>> > to do cross-project work on it :). Synergies. > > > >>>> > > > > >>>> > > > >>>> > > > >>>> -- > > > >>>> > > > >>>> Tomasz Urbaszek > > > >>>> Polidea <https://www.polidea.com/> | Software Engineer > > > >>>> > > > >>>> M: +48 505 628 493 <+48505628493> > > > >>>> E: [email protected] <[email protected]> > > > >>>> > > > >>>> Unique Tech > > > >>>> Check out our projects! <https://www.polidea.com/our-work> > > > >>>> > > > >>> > > > > > > > > > -- > > > > Jarek Potiuk > > Polidea <https://www.polidea.com/> | Principal Software Engineer > > > > M: +48 660 796 129 <+48660796129> > > [image: Polidea] <https://www.polidea.com/> > > > -- Jarek Potiuk Polidea <https://www.polidea.com/> | Principal Software Engineer M: +48 660 796 129 <+48660796129> [image: Polidea] <https://www.polidea.com/>
