Oh yeah. I forgot about the probot from Max -> Happy to contribute to it to add some of the functionality we might need :).
On Wed, Jan 1, 2020 at 11:42 PM Kaxil Naik <kaxiln...@gmail.com> wrote: > I loved *mergeable*. > One thing I realized after using the 4 Probot Integrations is that some of > the Probot apps are not actively maintained and might even be broken. > For example, *ci-reporter *didn't work for us and there are other users > facing > similar issues <https://github.com/JasonEtco/ci-reporter/issues/40>. > > I looked into other Probot apps including the one's suggested by Jarek and > the one Max created. > > - https://probot.github.io/apps/welcome/ : This one has this > <https://github.com/behaviorbot/welcome/issues/12> particular issue open > that might not make the experience pleasant for contributors. > - https://github.com/mithro/autolabeler: Need to test if it is working as > it looks a bit outdated (and not actively maintained - no replies on issues > <https://github.com/mithro/autolabeler/issues>), however it might still > work. > - https://probot.github.io/apps/pr-triage/ : Might be good to have but > this > issue <https://github.com/pr-triage/app/issues/181> might bite us too. Not > a major problem but just something to note. > - https://probot.github.io/apps/tests-checker/ : I liked this one > - https://probot.github.io/apps/reminders/ : Again might be outdated but > would need some testing to see if it actually works. > - https://github.com/z0al/dep : I liked this one too but it currently only > matches on "#PR_NUMBER". Open Issue <https://github.com/z0al/dep/issues/18> > so > would want to hear opinions from others. > > > @Max - I like your idea and maybe long term it might make more sense. Happy > to help in the effort so that we can make it more *general*. > But there are many advantages to building something that would also help us > avoid asking extra permissions from INFRA as well as make some general > features. > > I have also seen people shifting towards Github actions to do some of the > automation related to labels, comments, etc. > Does anyone have some opinion or experience with it vs Probot apps? > > Regards, > Kaxil > > On Tue, Dec 31, 2019 at 1:23 PM Jarek Potiuk <jarek.pot...@polidea.com> > wrote: > > > Yeah. we can remove commitlint from that list. I think Mergable is much > > better than commitlint looking at your recent configuration :) > > > > On Tue, Dec 31, 2019 at 2:14 PM Kaxil Naik <kaxiln...@gmail.com> wrote: > > > > > Once we have got all the configs for the current integrations, I will > > > review the ones you have provided in the link above and see if it is > > > achievable with the current ones or not. > > > > > > > > > > > > On Tue, Dec 31, 2019 at 1:06 PM Jarek Potiuk <jarek.pot...@polidea.com > > > > > wrote: > > > > > > > How about adding a few more apps ? I reviewed some probot apps and > > maybe > > > we > > > > should consider those: > > > > > > > > - https://probot.github.io/apps/welcome/ - Welcomes new users > > > > submitting > > > > their PRs for the first time > > > > - https://probot.github.io/apps/reminders/ - Allows to set > > reminders > > > > for > > > > certain issues by making a "/remind" comment > > > > - https://probot.github.io/apps/pr-triage/ - Assigns labels ("PR: > > > > unreviewed", "PR: reviewed-changes-requested", "PR: > > review-approved") > > > > - https://probot.github.io/apps/tests-checker/ - Reminds to > > > add/modify > > > > tests in "tests" dir when you submit code changes > > > > - https://github.com/mithro/autolabeler - Assigns labels > > > automatically > > > > based on paths matchers (for example providers/amazon/aws/* -> > "aws" > > > > label) > > > > - https://probot.github.io/apps/commitlint/ - Verifies if commit > > > > message > > > > is well formatted (including AIRFLOW-XXXX prefix] > > > > > > > > I am happy to open an issue and add configuration for those. > > > > > > > > Maybe later (After some discussion): > > > > > > > > - https://probot.github.io/apps/semantic-pull-requests/ -> that > > > > would require to introduce much more discipline in commit messages > > so > > > I > > > > am > > > > not sure it's a good idea now > > > > > > > > > > > > On Tue, Dec 31, 2019 at 1:29 PM Kaxil Naik <kaxiln...@gmail.com> > > wrote: > > > > > > > > > Yup. I am adding some configs. PRs coming in. > > > > > > > > > > On Tue, Dec 31, 2019 at 12:24 PM Jarek Potiuk < > > > jarek.pot...@polidea.com> > > > > > wrote: > > > > > > > > > > > Seems like we have a new friendly bot :) > > > > > > > > > > > > On Mon, Dec 30, 2019 at 8:41 AM Jarek Potiuk < > > > jarek.pot...@polidea.com > > > > > > > > > > > wrote: > > > > > > > > > > > > > I opened a few tickets for INFRA and I am also waiting for > > answer. > > > I > > > > > > guess > > > > > > > Xmas period got in the way. > > > > > > > > > > > > > > J. > > > > > > > > > > > > > > On Mon, Dec 30, 2019 at 5:15 AM Kevin Yang <yrql...@gmail.com> > > > > wrote: > > > > > > > > > > > > > >> +1! > > > > > > >> > > > > > > >> Kaxil Naik <kaxiln...@gmail.com>于2019年12月29日 周日下午6:21写道： > > > > > > >> > > > > > > >> > Thanks Max, > > > > > > >> > > > > > > > >> > I will raise a JIRA with the INFRA to add that too. > > > > > > >> > > > > > > > >> > Btw I had raised a request for the 4 integrations > > > > > > >> > https://issues.apache.org/jira/browse/INFRA-19607 but looks > > > like > > > > it > > > > > > >> hasn't > > > > > > >> > gained any traction from them yet. > > > > > > >> > > > > > > > >> > > > > > > > >> > > > > > > > >> > On Fri, Dec 20, 2019 at 8:29 PM Maxime Beauchemin < > > > > > > >> > maximebeauche...@gmail.com> wrote: > > > > > > >> > > > > > > > >> > > +1! > > > > > > >> > > > > > > > > >> > > I forgot whether I shared this before, but I wrote a > probot > > > for > > > > > > Apache > > > > > > >> > > Superset that does a few nice things, and we can grow over > > > time > > > > to > > > > > > do > > > > > > >> > more > > > > > > >> > > things without having to beg Apache Infra for anything > > > > (currently > > > > > > only > > > > > > >> > them > > > > > > >> > > have admin rights and can register apps on our repos) > > > > > > >> > > https://github.com/apache-superset/superset-github-bot > > > > > > >> > > > > > > > > >> > > This bot, for now [as documented on the README]: > > > > > > >> > > - enables non-committer to label/unlabel PRs and Issues > > using > > > > > > comments > > > > > > >> > > (allowing PMs and other non-committer to label things) > > > > > > >> > > - auto-labels all PRs and issues with a [whitelisted] > > > > organization > > > > > > >> (adds > > > > > > >> > an > > > > > > >> > > "airbnb" or "lyft" label to the PR) > > > > > > >> > > - enables forwarding events to other webhooks > > > > > > >> > > > > > > > > >> > > Eventually I'd like for it to also auto-label based on > > > > > files/folder > > > > > > >> that > > > > > > >> > > are touched in a PR: for instance "db-migration" or > > > "scheduler" > > > > or > > > > > > >> > > "webserver" would be nice. > > > > > > >> > > > > > > > > >> > > We could rename the bot to be an "Apache Github Bot" and > > keep > > > it > > > > > > >> > > generalized (it reads a yaml config file from the > project's > > > > repo, > > > > > so > > > > > > >> each > > > > > > >> > > feature of the bot can be configured on a per-project > > basis). > > > We > > > > > > could > > > > > > >> > > build a collection of things that other Apache projects > are > > > > likely > > > > > > to > > > > > > >> > want. > > > > > > >> > > We may even be able to automate some Apache email-driven > > > > processes > > > > > > >> using > > > > > > >> > > Github issues instead, for instance a committer vote > process > > > or > > > > > > >> release > > > > > > >> > > process vote could be automated by the bot: it would send > > > > emails, > > > > > > ask > > > > > > >> > > people to use reactions (thumbs up/down) and close the > vote > > / > > > > send > > > > > > the > > > > > > >> > > RESULTS email templates to the list. It could also look > for > > > ASF > > > > > > >> headers > > > > > > >> > in > > > > > > >> > > files (replacing the Apache-RAT). > > > > > > >> > > > > > > > > >> > > It could make for a great ApacheCon talk eventually as we > > add > > > > > > >> > > functionality. > > > > > > >> > > > > > > > > >> > > This is a pet project of mine for now, but I'd love to > make > > > room > > > > > for > > > > > > >> > people > > > > > > >> > > to jump in and contribute to it. > > > > > > >> > > > > > > > > >> > > Max > > > > > > >> > > > > > > > > >> > > On Fri, Dec 20, 2019 at 10:04 AM Huang Xinbin < > > > > > > bin.huan...@gmail.com> > > > > > > >> > > wrote: > > > > > > >> > > > > > > > > >> > > > +1 +1 (if I can vote XD) > > > > > > >> > > > > > > > > > >> > > > Best > > > > > > >> > > > Bin > > > > > > >> > > > > > > > > > >> > > > On 2019/12/20 13:43:11, Felix Uellendall > > > > <felue...@pm.me.INVALID > > > > > > > > > > > > >> > wrote: > > > > > > >> > > > > +1 > > > > > > >> > > > > > > > > > > >> > > > > Sent from ProtonMail Mobile > > > > > > >> > > > > > > > > > > >> > > > > On Fri, Dec 20, 2019 at 14:17, Tomasz Urbaszek < > > > > > > >> > > > tomasz.urbas...@polidea.com> wrote: > > > > > > >> > > > > > > > > > > >> > > > > > +1 for all four. > > > > > > >> > > > > > T. > > > > > > >> > > > > > > > > > > > >> > > > > > On Fri, Dec 20, 2019 at 2:12 PM Kamil Breguła < > > > > > > >> > > > kamil.breg...@polidea.com> > > > > > > >> > > > > > wrote: > > > > > > >> > > > > > > > > > > > >> > > > > >> +1 > > > > > > >> > > > > >> > > > > > > >> > > > > >> On Fri, Dec 20, 2019 at 8:43 AM Jarek Potiuk < > > > > > > >> > > > jarek.pot...@polidea.com> > > > > > > >> > > > > >> wrote: > > > > > > >> > > > > >> > > > > > > >> > > > > >> > +100 > > > > > > >> > > > > >> > > > > > > > >> > > > > >> > On Fri, Dec 20, 2019 at 7:02 AM hotmail < > > > > > > >> > > zhongjiajie...@hotmail.com > > > > > > >> > > > > > > > > > > >> > > > > >> > wrote: > > > > > > >> > > > > >> > > > > > > > >> > > > > >> > > I think the ci-reporter is great, because ours > CI > > > log > > > > > is > > > > > > >> > > tooooooo > > > > > > >> > > > long > > > > > > >> > > > > >> to > > > > > > >> > > > > >> > > read, and I just want to know what unittest > > failed > > > in > > > > > my > > > > > > PR > > > > > > >> > > > > >> > > > > > > > > >> > > > > >> > > Best Wish > > > > > > >> > > > > >> > > — Jiajie > > > > > > >> > > > > >> > > > > > > > > >> > > > > >> > > > > > > > > >> > > > > >> > > > > > > > >> > > > > >> > -- > > > > > > >> > > > > >> > > > > > > > >> > > > > >> > Jarek Potiuk > > > > > > >> > > > > >> > Polidea <https://www.polidea.com/> | Principal > > > > Software > > > > > > >> > Engineer > > > > > > >> > > > > >> > > > > > > > >> > > > > >> > M: +48 660 796 129 <+48660796129> > > > > > > >> > > > > >> > [image: Polidea] <https://www.polidea.com/> > > > > > > >> > > > > >> > > > > > > > >> > > > > >> > > > > > > >> > > > > > > > > > > > >> > > > > > -- > > > > > > >> > > > > > > > > > > > >> > > > > > Tomasz Urbaszek > > > > > > >> > > > > > Polidea <https://www.polidea.com/> | Junior > Software > > > > > Engineer > > > > > > >> > > > > > > > > > > > >> > > > > > M: +48 505 628 493 <+48505628493> > > > > > > >> > > > > > E: tomasz.urbas...@polidea.com < > > > > > tomasz.urbasz...@polidea.com> > > > > > > >> > > > > > > > > > > > >> > > > > > Unique Tech > > > > > > >> > > > > > Check out our projects! < > > > https://www.polidea.com/our-work > > > > > > > > > > > >> > > > > > > > > > >> > > > > > > > > >> > > > > > > > >> > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > > > > > > > > Jarek Potiuk > > > > > > > Polidea <https://www.polidea.com/> | Principal Software > Engineer > > > > > > > > > > > > > > M: +48 660 796 129 <+48660796129> > > > > > > > [image: Polidea] <https://www.polidea.com/> > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > > > > > > Jarek Potiuk > > > > > > Polidea <https://www.polidea.com/> | Principal Software Engineer > > > > > > > > > > > > M: +48 660 796 129 <+48660796129> > > > > > > [image: Polidea] <https://www.polidea.com/> > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > > Jarek Potiuk > > > > Polidea <https://www.polidea.com/> | Principal Software Engineer > > > > > > > > M: +48 660 796 129 <+48660796129> > > > > [image: Polidea] <https://www.polidea.com/> > > > > > > > > > > > > > -- > > > > Jarek Potiuk > > Polidea <https://www.polidea.com/> | Principal Software Engineer > > > > M: +48 660 796 129 <+48660796129> > > [image: Polidea] <https://www.polidea.com/> > > > -- Jarek Potiuk Polidea <https://www.polidea.com/> | Principal Software Engineer M: +48 660 796 129 <+48660796129> [image: Polidea] <https://www.polidea.com/>
