On Fri, 25 Mar 2022 at 20:40, Howard Yoo <howard...@gmail.com> wrote: > I am pleased to announce the start of the discussion for the new AIP draft > that was recently been published: > https://cwiki.apache.org/confluence/display/AIRFLOW/AIP-49+OpenTelemetry+Support+for+Apache+Airflow
Some comments: 1. The optional attributes added to the "incr", "desc", etc. methods seem wrong to me. It should be possible to specify this using some context abstraction in OpenTelemetry – that is, to more precisely define some scoped contexts within which the metrics or traces are logged. 2. I don't understand the need for `span_json` – it should be possible to pull these details from the existing objects (i.e. dagrun, task instance etc). 3. I think logging should be included even if it is in draft specification. We need distributed logging due to deferred tasks (work is shared between multiple worker task execution sessions, async executions). I doubt that logging will change much. Cheers
