On 3/29/2011 11:40 AM, Guenter Knauf wrote:
> Am 28.03.2011 20:24, schrieb Guenter Knauf:
>> and that seems to work - it skips the useless testing for *mingw* and
>> sets the right typedef in apr.h, and the warning is then also gone;
>> but not sure if its the right patch ...
> with this one and all the other recent fixes apr-1.4.x looks now pretty good
> - only 3
> warnings remain now with misc/win32/start.c;
> I've just build a round with clang to make the issues a bit more clear:
> http://people.apache.org/~fuankg/mingw/build_w32_msys_clang.txt.gz
>
> if whe want to avoid further casts then we probably need to change wchar_t to
> apr_wchar_t
> - but that cant be done unconditionally because the presense of apr_wchar_t
> depends on an
> unicode_fs define ...
>
> Bill, are you in the mood to take a look at this?
Quick observations...
clang -E -DHAVE_CONFIG_H -DWIN32 -D__MSVCRT__ -D_LARGEFILE64_SOURCE
-I./include
-I/home/Administrator/apr/apr-1.4.x/apr/include/arch/win32 -I./include/arch/unix
-I/home/Administrator/apr/apr-1.4.x/apr/include/arch/unix
-I/home/Administrator/apr/apr-1.4.x/apr/include exports.c | grep "ap_hack_" |
sed -e
's/^.*[)]\(.*\);$/\1/' >> apr.exp
In file included from exports.c:12:
In file included from
D:/MinGW/msys/1.0/home/Administrator/apr/apr-1.4.x/apr/include/apr_allocator.h:25:
./include/apr.h:150:10: fatal error: 'windows.h' file not found
#include <windows.h>
^
1 error generated.
What is *that* about? :)
On the wargs, I believe we are replacing that code; I'm creating a VC10
environment for
validation right now so I can better understand if the proposed fix for environ
allocs
is going to be the solution to all of the msvcrXXX flavors. Provided it does,
I'll get
that committed very shortly.
