> On 5 7, 2019, 7:05 오후, Asif Hoda wrote: > > addons/models/1000-Hadoop/1090-spark_model.json > > Lines 1 (patched) > > <https://reviews.apache.org/r/70600/diff/1/?file=2143548#file2143548line1> > > > > I believe we should have the following value for most of the entitiies: > > > > 1. "isIndexable": true > > 2. isOptional": false > > 3. "isUnique": true > > > > Do we need to discuss these further ?
I guess all of models are inherited from `Referenceable` which should have `qualifiedName` attribute. Isn't it enough? - Jungtaek ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70600/#review215097 ----------------------------------------------------------- On 5 7, 2019, 8:01 오후, Aadarsh Jajodia wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70600/ > ----------------------------------------------------------- > > (Updated 5 7, 2019, 8:01 오후) > > > Review request for atlas, Ashutosh Mestry, Jungtaek Lim, Sridhar K, Le Ma, > Madhan Neethiraj, and Sarath Subramanian. > > > Repository: atlas > > > Description > ------- > > This is an initial mode file for the SPARK models. Please refer to the file > added here. This file is a GET call on typeDefs on a cluster which had SAC > enabled and SAC has created the models. The SAC version used was > https://github.com/hortonworks/spark-atlas-connector/tree/SAC-CDP-1.0-dev > > > Diffs > ----- > > addons/models/1000-Hadoop/1090-spark_model.json PRE-CREATION > > > Diff: https://reviews.apache.org/r/70600/diff/1/ > > > Testing > ------- > > > File Attachments > ---------------- > > SAC Models > > https://reviews.apache.org/media/uploaded/files/2019/05/07/e31827b2-04c5-4fab-b5b7-4271398831e4__spark_sac_api_model_definition.txt > > > Thanks, > > Aadarsh Jajodia > >
