----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70600/#review215285 -----------------------------------------------------------
addons/models/1000-Hadoop/1090-spark_model.json Lines 8 (patched) <https://reviews.apache.org/r/70600/#comment301946> give a meaningful description value - "Spark Database"; Please review other description as well. addons/models/1000-Hadoop/1090-spark_model.json Lines 9 (patched) <https://reviews.apache.org/r/70600/#comment301947> add "serviceType": "spark" for each spark type; please review for other types in spark as well. addons/models/1000-Hadoop/1090-spark_model.json Lines 10 (patched) <https://reviews.apache.org/r/70600/#comment301949> consider including "searchWeight" for relavent fields which might be used for search. addons/models/1000-Hadoop/1090-spark_model.json Lines 44 (patched) <https://reviews.apache.org/r/70600/#comment301948> move "superTypes" above next to - name, description, superTypes; to be consistent with other model types - Sarath Subramanian On May 15, 2019, 12:39 p.m., Aadarsh Jajodia wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70600/ > ----------------------------------------------------------- > > (Updated May 15, 2019, 12:39 p.m.) > > > Review request for atlas, Ankur Gupta, Arun Mahadevan, Ashutosh Mestry, > Jungtaek Lim, Sridhar K, Le Ma, Madhan Neethiraj, and Sarath Subramanian. > > > Repository: atlas > > > Description > ------- > > This is an initial mode file for the SPARK models. Please refer to the file > added here. This file is a GET call on typeDefs on a cluster which had SAC > enabled and SAC has created the models. The SAC version used was > https://github.com/hortonworks/spark-atlas-connector/tree/SAC-CDP-1.0-dev > > > Diffs > ----- > > addons/models/1000-Hadoop/1090-spark_model.json PRE-CREATION > > > Diff: https://reviews.apache.org/r/70600/diff/1/ > > > Testing > ------- > > > File Attachments > ---------------- > > SAC Models > > https://reviews.apache.org/media/uploaded/files/2019/05/07/e31827b2-04c5-4fab-b5b7-4271398831e4__spark_sac_api_model_definition.txt > > > Thanks, > > Aadarsh Jajodia > >
