----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70600/#review215266 -----------------------------------------------------------
addons/models/1000-Hadoop/1090-spark_model.json Lines 22 (patched) <https://reviews.apache.org/r/70600/#comment301908> This should not be optional. If you refer to the corresponding hive model, it is not optional addons/models/1000-Hadoop/1090-spark_model.json Lines 49 (patched) <https://reviews.apache.org/r/70600/#comment301913> Jungtaek, if you look at the spark table and see the differences between spark and hive table and let us know if these differences are expected and fine. addons/models/1000-Hadoop/1090-spark_model.json Lines 139 (patched) <https://reviews.apache.org/r/70600/#comment301909> In the corresponding hive_column models i see there is something called a position attribute. Are we expecting to not have that attribute for Spark Column addons/models/1000-Hadoop/1090-spark_model.json Lines 207 (patched) <https://reviews.apache.org/r/70600/#comment301911> I just wanted to highlight that i see some differences between spark storage desc and hive storage desc in the attributes addons/models/1000-Hadoop/1090-spark_model.json Lines 249 (patched) <https://reviews.apache.org/r/70600/#comment301910> Why is this set to true here? Any particular reason? addons/models/1000-Hadoop/1090-spark_model.json Lines 313 (patched) <https://reviews.apache.org/r/70600/#comment301915> This should be changed to date type. I will update in the next version - Aadarsh Jajodia On May 10, 2019, 9:18 p.m., Aadarsh Jajodia wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70600/ > ----------------------------------------------------------- > > (Updated May 10, 2019, 9:18 p.m.) > > > Review request for atlas, Ankur Gupta, Ashutosh Mestry, Jungtaek Lim, Sridhar > K, Le Ma, Madhan Neethiraj, and Sarath Subramanian. > > > Repository: atlas > > > Description > ------- > > This is an initial mode file for the SPARK models. Please refer to the file > added here. This file is a GET call on typeDefs on a cluster which had SAC > enabled and SAC has created the models. The SAC version used was > https://github.com/hortonworks/spark-atlas-connector/tree/SAC-CDP-1.0-dev > > > Diffs > ----- > > addons/models/1000-Hadoop/1090-spark_model.json PRE-CREATION > > > Diff: https://reviews.apache.org/r/70600/diff/1/ > > > Testing > ------- > > > File Attachments > ---------------- > > SAC Models > > https://reviews.apache.org/media/uploaded/files/2019/05/07/e31827b2-04c5-4fab-b5b7-4271398831e4__spark_sac_api_model_definition.txt > > > Thanks, > > Aadarsh Jajodia > >
