----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70600/#review215177 -----------------------------------------------------------
Ship it! I think it's better to point to public repository when referring some other project: Apache Atlas is one of the ASF projects. So we can replace the link to https://github.com/hortonworks-spark/spark-atlas-connector/commits/master, more clearly https://github.com/hortonworks-spark/spark-atlas-connector/commit/ec30195c045424e8543f646c479cbc99395c7261 Btw, I have tested the json models via adding file to vanilla Atlas 1.1 and run Atlas via standalone mode, and ran basic queries with latest SAC. Looks good. - Jungtaek Lim On 5 7, 2019, 8:01 오후, Aadarsh Jajodia wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70600/ > ----------------------------------------------------------- > > (Updated 5 7, 2019, 8:01 오후) > > > Review request for atlas, Ashutosh Mestry, Jungtaek Lim, Sridhar K, Le Ma, > Madhan Neethiraj, and Sarath Subramanian. > > > Repository: atlas > > > Description > ------- > > This is an initial mode file for the SPARK models. Please refer to the file > added here. This file is a GET call on typeDefs on a cluster which had SAC > enabled and SAC has created the models. The SAC version used was > https://github.com/hortonworks/spark-atlas-connector/tree/SAC-CDP-1.0-dev > > > Diffs > ----- > > addons/models/1000-Hadoop/1090-spark_model.json PRE-CREATION > > > Diff: https://reviews.apache.org/r/70600/diff/1/ > > > Testing > ------- > > > File Attachments > ---------------- > > SAC Models > > https://reviews.apache.org/media/uploaded/files/2019/05/07/e31827b2-04c5-4fab-b5b7-4271398831e4__spark_sac_api_model_definition.txt > > > Thanks, > > Aadarsh Jajodia > >
