-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70600/#review215080
-----------------------------------------------------------




addons/models/1000-Hadoop/1090-spark_model.json
Lines 395 (patched)
<https://reviews.apache.org/r/70600/#comment301494>

    When both ends have isLegacyAttribute=true, consider adding 
'relationshipLabel' filed to the relationship-def. This will eliminate the need 
to create 2 edges (as in legacy case) - end1->end2 & end2->end1.
    
    Please review and update following relationship-defs:
     - spark_table_columns
     - spark_table_storagedesc


- Madhan Neethiraj


On May 7, 2019, 8:01 p.m., Aadarsh Jajodia wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70600/
> -----------------------------------------------------------
> 
> (Updated May 7, 2019, 8:01 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Jungtaek Lim, Sridhar K, Le Ma, 
> Madhan Neethiraj, and Sarath Subramanian.
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> This is an initial mode file for the SPARK models. Please refer to the file 
> added here. This file is a GET call on typeDefs on a cluster which had SAC 
> enabled and SAC has created the models. The SAC version used was 
> https://github.com/hortonworks/spark-atlas-connector/tree/SAC-CDP-1.0-dev
> 
> 
> Diffs
> -----
> 
>   addons/models/1000-Hadoop/1090-spark_model.json PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/70600/diff/1/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> SAC Models
>   
> https://reviews.apache.org/media/uploaded/files/2019/05/07/e31827b2-04c5-4fab-b5b7-4271398831e4__spark_sac_api_model_definition.txt
> 
> 
> Thanks,
> 
> Aadarsh Jajodia
> 
>

Reply via email to