+1 (non-binding). Tested Java quickstart for Direct/Dataflow runners and multi-language pipelines.
Thanks, Cham On Thu, Jan 7, 2021 at 10:47 AM Pablo Estrada <pabl...@google.com> wrote: > Thanks Valentyn, > these were built using Maven 3.6.0, and OpenJDK version 1.8.0_232. > Best > -P. > > On Thu, Jan 7, 2021 at 9:45 AM Yichi Zhang <zyi...@google.com> wrote: > >> +1, I verified the python mobile game walkthrough on core runners. >> >> On Thu, Jan 7, 2021 at 8:29 AM Valentyn Tymofieiev <valen...@google.com> >> wrote: >> >>> On Thu, Jan 7, 2021 at 8:06 AM Ismaël Mejía <ieme...@gmail.com> wrote: >>> >>>> > Also I wonder if we now need to clarify both Java 8 and Java 11 >>>> versions separately? >>>> >>>> You mean for the docker images? Otherwise we should not be using Java >>>> 11 at all to produce the artifacts. >>>> >>> >>> Thanks for clarification, yes, looks like Docker images are the only >>> artifacts where this concern applies. The Docker images include several >>> jars[1], that I believe are currently built locally (by a release manager >>> at container image build time). Are the jars included in Java 11 images >>> built with Java 11? If so, is it worth calling out the compiler? Also, >>> perhaps we should look into building release artifacts using Jenkins or >>> Github Actions, with a preconfigured version of compilers, instead of >>> whatever version is installed on the release manager's machine. >>> >>> [1] >>> https://github.com/apache/beam/blob/master/sdks/java/container/Dockerfile#L24-L33 >>> >>> >>>> >>>> On Thu, Jan 7, 2021 at 4:51 PM Valentyn Tymofieiev <valen...@google.com> >>>> wrote: >>>> > >>>> > Noting that announcement does not include the version of the Java >>>> compilers used - looks like the release guide still requires it: >>>> > >>>> > * Java artifacts were built with Maven MAVEN_VERSION and >>>> OpenJDK/Oracle JDK JDK_VERSION. >>>> > >>>> > >>>> > Could you please add this info to this thread for posterity? >>>> > >>>> > Also I wonder if we now need to clarify both Java 8 and Java 11 >>>> versions separately? >>>> > >>>> > Other than that, +1 from me. Ran several mobile gaming pipelines on >>>> Direct and Dataflow runners with Python 3.8. >>>> > >>>> > On Thu, Jan 7, 2021 at 12:49 AM Jan Lukavský <je...@seznam.cz> wrote: >>>> >> >>>> >> +1 (non-binding). >>>> >> >>>> >> I've validated the RC against my dependent projects (mainly Java >>>> SDK, Flink and DirectRunner). >>>> >> >>>> >> Thanks, >>>> >> >>>> >> Jan >>>> >> >>>> >> On 1/7/21 2:15 AM, Ahmet Altay wrote: >>>> >> >>>> >> +1 (binding) - validated python quickstarts. >>>> >> >>>> >> Thank you Pablo. >>>> >> >>>> >> On Wed, Jan 6, 2021 at 1:57 PM Pablo Estrada <pabl...@google.com> >>>> wrote: >>>> >>> >>>> >>> +1 (binding) >>>> >>> I've built and unit tested existing Dataflow Templates with the new >>>> version. >>>> >>> Best >>>> >>> -P. >>>> >>> >>>> >>> On Tue, Jan 5, 2021 at 11:17 PM Pablo Estrada <pabl...@google.com> >>>> wrote: >>>> >>>> >>>> >>>> Hi everyone, >>>> >>>> Please review and vote on the release candidate #4 for the version >>>> 2.27.0, as follows: >>>> >>>> [ ] +1, Approve the release >>>> >>>> [ ] -1, Do not approve the release (please provide specific >>>> comments) >>>> >>>> >>>> >>>> NOTE. What happened to RC #2? I started building RC2 before >>>> completing all the cherry-picks, so the tag for RC2 was created on an >>>> incorrect commit. >>>> >>>> >>>> >>>> NOTE. What happened to RC #3? I started building RC3, but a new >>>> bug was discovered (BEAM-11569) that required amending the branch. Thus >>>> this is now RC4. >>>> >>>> >>>> >>>> Reviewers are encouraged to test their own use cases with the >>>> release candidate, and vote +1 >>>> >>>> if no issues are found. >>>> >>>> >>>> >>>> The complete staging area is available for your review, which >>>> includes: >>>> >>>> * JIRA release notes [1], >>>> >>>> * the official Apache source release to be deployed to >>>> dist.apache.org [2], which is signed with the key with fingerprint >>>> C79DDD47DAF3808F0B9DDFAC02B2D9F742008494 [3], >>>> >>>> * all artifacts to be deployed to the Maven Central Repository [4], >>>> >>>> * source code tag "v2.27.0-RC4" [5], >>>> >>>> * website pull request listing the release [6], publishing the API >>>> reference manual [7], and the blog post [8]. >>>> >>>> * Python artifacts are deployed along with the source release to >>>> the dist.apache.org [2]. >>>> >>>> * Validation sheet with a tab for 2.27.0 release to help with >>>> validation [9]. >>>> >>>> * Docker images published to Docker Hub [10]. >>>> >>>> >>>> >>>> The vote will be open for at least 72 hours, but given the >>>> holidays, we will likely extend for a few more days. The release will be >>>> adopted by majority approval, with at least 3 PMC affirmative votes. >>>> >>>> >>>> >>>> Thanks, >>>> >>>> -P. >>>> >>>> >>>> >>>> [1] >>>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12319527&version=12349380 >>>> >>>> [2] https://dist.apache.org/repos/dist/dev/beam/2.27.0/ >>>> >>>> [3] https://dist.apache.org/repos/dist/release/beam/KEYS >>>> >>>> [4] >>>> https://repository.apache.org/content/repositories/orgapachebeam-1149/ >>>> >>>> [5] https://github.com/apache/beam/tree/v2.27.0-RC4 >>>> >>>> [6] https://github.com/apache/beam/pull/13602 >>>> >>>> [7] https://github.com/apache/beam-site/pull/610 >>>> >>>> [8] https://github.com/apache/beam/pull/13603 >>>> >>>> [9] >>>> https://docs.google.com/spreadsheets/d/1qk-N5vjXvbcEk68GjbkSZTR8AGqyNUM-oLFo_ZXBpJw/edit#gid=194829106 >>>> >>>> [10] https://hub.docker.com/search?q=apache%2Fbeam&type=image >>>> >>>
