I have a PR for CALCITE-4446, https://github.com/apache/calcite/pull/2357. I'd be grateful if people could review & test.
On Mon, Feb 22, 2021 at 12:39 PM Julian Hyde <jhyde.apa...@gmail.com> wrote: > > I’m working hard on 4446. It may still be a few days. > > > On Feb 21, 2021, at 1:00 PM, Stamatis Zampetakis <zabe...@gmail.com> wrote: > > > > At the moment we are mainly waiting for CALCITE-4446 [1], CALCITE-4488 [2], > > for preparing the first RC for 1.27.0. > > > > I know that some people started testing the current master (thanks!) and it > > would be great if others start doing so as soon as possible in order to > > have a smooth release. > > If testing with master is not feasible, testing with 1.26.0 and providing > > feedback (positive or negative) can also help a lot. > > > > Best, > > Stamatis > > > > <https://issues.apache.org/jira/browse/CALCITE-4446>[1] > > https://issues.apache.org/jira/browse/CALCITE-4446 > > [2] https://issues.apache.org/jira/browse/CALCITE-4488 > > > > > > > > On Thu, Feb 4, 2021 at 10:36 AM Stamatis Zampetakis <zabe...@gmail.com> > > wrote: > > > >> OK so if I understand well for the next release we should aim to finish > >> CALCITE-4446, CALCITE-4405, and CALCITE-4487. > >> > >> It would be good if people can test 1.26.0 or the current master now so > >> that we can see what else needs to be done for 1.27.0. > >> > >> Best, > >> Stamatis > >> > >> On Wed, Feb 3, 2021 at 9:46 AM Vladimir Sitnikov < > >> sitnikov.vladi...@gmail.com> wrote: > >> > >>> Julian>because we never had a test case that indicated how actual behavior > >>> differed from desired behavior > >>> > >>> One of the tests has been included in Calcite sources for a while. Please > >>> refer to RexProgramFuzzyTest that I previously highlighted in > >>> "Search/Sarg: untested feature merged to the default branch" thread: > >>> > >>> https://lists.apache.org/thread.html/rce6e84d0e0cd5a227d64c9f670b43650833f43e0cbccb80e04f5e0cf%40%3Cdev.calcite.apache.org%3E > >>> > >>> Note: I believe "Sarg feature" should have been accompanied by the > >>> relevant > >>> additions to RefFuzzer, RexShrinker, and RexInterpreter as a part of the > >>> test > >>> coverage. > >>> Under the current implementation, users can't avoid/disable SEARCH/Sarg, > >>> and it is enabled by default, so the feature must come with tests. > >>> > >>> Vladimir > >>> > >> >
