On 14 February 2012 12:13, Raul Kripalani <r...@fusesource.com> wrote:
> Hi Bilgin, > > Apologies for the delay in my reply. > > Regarding the unit test depending on an installation of MongoDB, there is > really no way out. There is nothing out there to support an embedded > instance of MongoDB (have spent hours searching). Moreover, MongoDB is > really a C application, so even if we were to automate fetching and > installing MongoDB on a temp directory as part of the test process, it > would be some hairy logic because you first need to detect what platform, > environment and bitness the test is running. Overall, the test would have a > higher chance of failing than the code itself :P > hmmm. I wonder how these test would run on CI server or on user machienes. May be there is way that Iam not aware of. > > Mocking it out wasn't really an option here as it provides no value in this > scenario IMHO. > > Concerning the constant interface pattern, I don't think it's the way to > go. It has been named an anti-pattern in a Sun book: > > http://stackoverflow.com/questions/2659593/what-is-the-use-of-interface-constants > . > ok, I just notice the repetition of "public static final" on each line, also the new components that are added to Camel seems to be using interfaces... I'm fine with both versions really. > Thanks for the feedback! > > Regards, > Raúl. > > On 3 February 2012 14:19, Bilgin Ibryam <bibr...@gmail.com> wrote: > > > Hi Raul, > > > > I had a look and the mongodb component, it looks ready, great job. > > Few notes: > > > > I think the unit test should not depend on existing mongodb > > installation, it would be great if there is an inmemory or mock > > implementation and the tests start it up for example. > > > > Minor, you can make MongoDbConstants an interface with constants > > And this fields seems not to be used INSERT_RECORDS_AFFECTED > > > > Cheers, > > Bilgin > > > > > > > > On 27 January 2012 14:19, Raul Kripalani <r...@fusesource.com> wrote: > > > Hi everybody, > > > > > > The source for the camel-mongodb component is available here: Camel > > > MongoDB<https://github.com/raulk/camel-mongodb>( > > > https://github.com/raulk/camel-mongodb). > > > > > > A few items are still pending on my task list, namely: Javadoc and > > > reordering of methods to match the (1) getters/setters and (2) > > > implementation methods pattern. But at this point I wanted to give you > a > > > sneak peek into it. Please feel free to comment on the code. > > > > > > What's the timeline for the 2.10 release? I'd be great if this > component > > > makes it into it. > > > > > > Regards, > > > Raúl Kripalani (@raulvk <https://twitter.com/raulvk>) > > > FuseSource > > > > > > On 10 January 2012 02:48, Raul Kripalani <r...@fusesource.com> wrote: > > > > > >> Ticket created: https://issues.apache.org/jira/browse/CAMEL-4878. > > >> > > >> Bilgin, I'm already working on the code. Will let you know in case I > > need > > >> help. Thanks! > > >> > > >> -- Raúl. > > >> > > >> On 9 January 2012 10:38, Bilgin Ibryam <bibr...@gmail.com> wrote: > > >> > > >>> Hi Raul, > > >>> > > >>> > For a first embracement of MongoDB, it seems more natural to > > implement a > > >>> > raw component which can handle at least the following MongoDB > > >>> > operations: insert, findOne, count, findAll, query, mapReduce, > > getStats, > > >>> > group, save, update, remove, updateMulti. > > >>> > > > >>> > > >>> If you start the development using camel-jira I can also help for > > >>> testing and coding... > > >>> > > >>> > Then we can start thinking about Morphia. > > >>> > > > >>> > Do you agree? > > >>> > > >>> Makes sense. > > >>> > > >>> Cheers > > >>> Bilgin > > >>> > > >>> > > > >>> > Regards, > > >>> > Raúl. > > >>> > > > >>> > On 4 January 2012 09:35, Ioannis Canellos <ioca...@gmail.com> > wrote: > > >>> > > > >>> >> I've used morphia a lot last year and I was very happy with it. > > >>> However, I > > >>> >> think that we should not base a mongodb component on that. > > >>> >> > > >>> >> I think that we need a pure camel-mongodb component and we could > > have a > > >>> >> morphia dataformat or a separate morphia component. > > >>> >> > > >>> >> -- > > >>> >> *Ioannis Canellos* > > >>> >> * > > >>> >> FuseSource <http://fusesource.com> > > >>> >> > > >>> >> ** > > >>> >> Blog: http://iocanel.blogspot.com > > >>> >> ** > > >>> >> Apache Karaf <http://karaf.apache.org/> Committer & PMC > > >>> >> Apache Camel <http://camel.apache.org/> Committer > > >>> >> Apache ServiceMix <http://servicemix.apache.org/> Committer > > >>> >> Apache Gora <http://incubator.apache.org/gora/> Committer > > >>> >> Apache DirectMemory <http://incubator.apache.org/directmemory/> > > >>> Committer > > >>> >> * > > >>> >> > > >>> > > >> > > >> > > >
