On Thu, Aug 19, 2010 at 5:56 PM, Noah Slater <[email protected]> wrote: > > On 19 Aug 2010, at 16:49, Benoit Chesneau wrote: > >> Well asking without giving yourself some data make it irrelevant but > > Not really. > > I'm suggesting that if we're going to use performance as an argument, we use > data and not supposition.
The way pattern matching works should explain by itself though ;) > >> Pattern matching is more efficient in erlang. Why would would you use >> regexp where it's not needed. regexp give an extra level of complexity >> we don't need here. > > Should "we" be "I" in that sentence? :) *I* was speaking for the project, maybe I'm too much implicated :/ Now I won't try to prove anything, I'm too much busy these day unfortunately. I just used what I thought was the right tool. Same system is used in _rewrite handler so why using another way to do it. Btw, regexp was tried for _rewrite too and it would have slow the process + make it more difficult to use . Now I can remove this pattern matching from the code, but the problem Jason raised will stay. Current system in trunk doesn't change anything to the way vhosts are actually handled in 1.0.1, so the problem Jason have is already in 1.0.1. What I see on the other hand is that couchone.com is running. Also, I introduced the X-Forwarded-Host especially for reverse-proxy and it should solve that.
