Hi Sergey, On Sun, Mar 13, 2011 at 2:50 PM, Sergey Beryozkin <sberyoz...@gmail.com> wrote: > Hi Tomasz > > thanks for your effort, comments inline, > >> At the moment URL looks like: >> >> >> <endpoint_url>s?_s=date=ge=2011-03-07;date=lt=2011-03-07;level==DEBUG,level==INFO,level==WARN,level==ERROR >> > > There is one more update needed: > > _s=date=ge=2011-03-07;date=lt=2011-03-07;(level==DEBUG,level==INFO,level==WARN,level==ERROR) > > Please note the brackets around the multiple OR level condition. So the > above says "all the records within the given date range *and* its level > equal to INFO *or* DEBUG, etc" > > Can you do a sanity check please and confirm that only those filter fields > which are selected are added to the URI ? > Example, if the filter becomes empty then the query is set to null/empty > value, if only the 'from' date field selected then it is > > _s=date=lt=2011-03-07 > > only. And yes, the message value should have '*' symbols on both ends of the > entered value....
Done. Some variations from current implementation: /log/logs?_s=phrase==*test%20test*;date=ge=2011-03-17;date=lt=2011-03-07;(level==INFO,level==WARN) /log/logs?_s=phrase==*test*;date=ge=2011-03-17;date=lt=2011-03-07;(level==INFO,level==WARN) /log/logs?_s=level==INFO,level==WARN /log/logs?_s=date=ge=2011-03-23 >> >> >> > - Remove the Authentication/SignIn/SignOut related code/resources. We >> >> > just >> >> > don't have time now to deal with the authentication/security issues >> >> > and >> >> > we'd >> >> > need to have another discussion later on about it. I believe you >> >> > agreed >> >> > to >> >> > it too. >> >> >> >> I'm working on it right now. I almost finished. >> >> Done. >> > Brilliant - please be assured that we will discuss the issue of the > authentication and the use of HTTPs later on, in due time. > > One thing I noticed in your merge email is that it said that storing the > user settings in the local cache was also removed. But we should actually > keep it ? So that after we start the browser again it remembers the > information about the endpoints ? If you did remove this code then please > restore it... At the moment it works like: - Start application; - Load settings from BootStrapStorage web service to memory (later we use settings from memory); - There is synchronization with BootStrapStorage when you add/remove/edit endpoint; ...this solution is according to your quote: " I think it makes sense to keep the list of endpoints and the filter properties the current user has created. *But*, these settings just need to shared across multiple restarts of the browser between all the users. This is because I don't really think it is realistic that one user will want to see EndpointA only, the other one, EndpointB, etc. So lets keep it - I'm not worried about many users using different browsers for checking the logs of the single server :-) " ...I think it's a good idea - users can share settings. I don't consider filter options as settings. It's something per user and only during the session. >> >> > - Explain a bit which code/script deals with processing the dates. I >> >> > know >> >> > you spent a lot of time on trying to reproduce the application >> >> > exception, >> >> > including testing it on Ubuntu, but I'd like to give it a try and see >> >> > if >> >> > I >> >> > can spot something that causes the issue on my particular OS - if I >> >> > can >> >> > trace it to some bad Java or Firefox installation then I'll get >> >> > relaxed >> >> > :-)... >> >> I added helper classes and static resource which support GWT debug mode. >> >> To execute application in debug mode please fallow instructions: >> >> Run application: >> >> 1) To run LogBorwser in the debug mode, you must type in the terminal: >> mvn clean gwt:run -Pdev >> 2) Open new browser's window and go to: >> >> http://127.0.0.1:8888/logbrowser/LogBrowser.html?gwt.codesvr=127.0.0.1:9997 >> >> Configure settings: >> >> 4) Add new endpoint with URL: >> http://127.0.0.1:8888/log/logs >> 5) Generate entry logs by interacting with URL: >> http://127.0.0.1:8888/generate.html > > Great - hopefully that will let me trace the problem with dates. > > Thanks, Sergey > -- Best regards, Tomasz Oponowicz
