stevedlawrence commented on a change in pull request #218: Implement dfdl:choiceLength='explicit' URL: https://github.com/apache/incubator-daffodil/pull/218#discussion_r291311227
########## File path: daffodil-runtime1-unparser/src/main/scala/org/apache/daffodil/processors/unparsers/ChoiceAndOtherVariousUnparsers.scala ########## @@ -43,7 +44,11 @@ class ComplexTypeUnparser(rd: RuntimeData, bodyUnparser: Unparser) } } -class ChoiceCombinatorUnparser(mgrd: ModelGroupRuntimeData, eventUnparserMap: Map[ChoiceBranchEvent, Unparser]) +class ChoiceCombinatorUnparser( + mgrd: ModelGroupRuntimeData, + eventUnparserMap: Map[ChoiceBranchEvent, Unparser], + choiceLengthKind: ChoiceLengthKind, + choiceLengthInBits: Long) Review comment: I think if this becomes a ``Maybe[Long]`` then you don't need to pass in choiceLengthKind? So changing the type does simplify things a bit. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
