stevedlawrence commented on a change in pull request #218: Implement dfdl:choiceLength='explicit' URL: https://github.com/apache/incubator-daffodil/pull/218#discussion_r291324294
########## File path: daffodil-io/src/main/scala/org/apache/daffodil/io/DataOutputStream.scala ########## @@ -24,6 +24,7 @@ import org.apache.daffodil.util.Logging import org.apache.daffodil.util.Maybe sealed abstract class ZeroLengthStatus +extends Serializable Review comment: But isn't the SuspendableOperation only allocated at Runtime? So its shouldn't need to be serialized. Again, not a big deal, but I feel like maybe I'm missing something. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
