stevedlawrence commented on a change in pull request #218: Implement dfdl:choiceLength='explicit' URL: https://github.com/apache/incubator-daffodil/pull/218#discussion_r291310989
########## File path: daffodil-io/src/main/scala/org/apache/daffodil/io/DataOutputStream.scala ########## @@ -24,6 +24,7 @@ import org.apache.daffodil.util.Logging import org.apache.daffodil.util.Maybe sealed abstract class ZeroLengthStatus +extends Serializable Review comment: Any idea why this needs to be serializable now? Not a big deal, but this feels like a runtime thing that shouldn't need to be serialized? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
