stevedlawrence commented on a change in pull request #218: Implement 
dfdl:choiceLength='explicit'
URL: https://github.com/apache/incubator-daffodil/pull/218#discussion_r291320137
 
 

 ##########
 File path: 
daffodil-runtime1-unparser/src/main/scala/org/apache/daffodil/processors/unparsers/SuppressableSeparatorUnparser.scala
 ##########
 @@ -136,28 +137,6 @@ final class 
SuppressableSeparatorUnparserSuspendableOperation(
     }
   }
 
-  /**
-   * Given two DataOutputStream, determine the set of data output streams 
starting from the first,
-   * and in chain until (and including) we reach the second.
-   *
-   * If the two are the same DataOutputStream, we get back a sequence of just 
the one DOS.
-   */
-  private def getDOSFromAtoB(beforeDOS: DataOutputStream, afterDOS: 
DataOutputStream): Seq[DataOutputStream] = {
 
 Review comment:
   Did you move this to another file and forget to add it? It looks like it's 
stilll used above but I don't see it added back anywhere.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to