stevedlawrence commented on a change in pull request #218: Implement dfdl:choiceLength='explicit' URL: https://github.com/apache/incubator-daffodil/pull/218#discussion_r291326128
########## File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/RuntimePropertyMixins.scala ########## @@ -46,6 +46,8 @@ import org.apache.daffodil.schema.annotation.props.gen.DFDLBaseTypeMixin import org.apache.daffodil.schema.annotation.props.gen.DFDLSimpleTypeMixin import org.apache.daffodil.schema.annotation.props.gen.LengthAGMixin import org.apache.daffodil.schema.annotation.props.gen.LengthKind +import org.apache.daffodil.schema.annotation.props.gen.ChoiceLengthKind Review comment: Now that you mention, I think you're right. I think maybe when we added support for scala 2.12 we removed some build options that were scala 2.11 only. It looks like in 2.11 the build flag is ``-Ywarn-unused-import`` and scala 2.12 is ``-Ywarn-unused:imports`` (note the colon and the plural). So if we want this back (seems reasonable), we'd need to conditionally add the right option to scalacOptions based on scalaVersion. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
