arina-ielchiieva commented on a change in pull request #1345: DRILL-6494: Drill
Plugins Handler
URL: https://github.com/apache/drill/pull/1345#discussion_r198844552
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/store/NamedStoragePluginConfig.java
##########
@@ -25,6 +25,14 @@
public class NamedStoragePluginConfig extends StoragePluginConfig {
public String name;
+ public String getName() {
+ return name;
+ }
+
+ public void setName(String name) {
+ this.name = name;
+ }
+
Review comment:
1. In hashCode method we have: `name.hashCode()`. What if name is null?
2. Why equals checks only `this == o;`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
