If time allows then we could also include FLINK-21030 [1]. We are about to merge this fix.
[1] https://issues.apache.org/jira/browse/FLINK-21030 Cheers, Till On Thu, Feb 25, 2021 at 4:13 PM Roman Khachatryan <ro...@apache.org> wrote: > Hi everyone, > > The issue which caused the previous RC cancellation is now resolved [1]. > > There are two more issues that we'd like to include in 1.12.2 [2][3]. > Yuan and I are going to prepare the next RC (#2) once they are resolved. > > Please let us know if there are any other issues blocking the RC. > Currently, the dashboard doesn't show any blockers [4]. > > > [1] https://issues.apache.org/jira/browse/FLINK-21453 > [2] https://issues.apache.org/jira/browse/FLINK-21490 > [3] https://issues.apache.org/jira/browse/FLINK-21452 > [4] https://s.apache.org/flink-1.12.2-blockers > > Regards, > Roman > > > On Mon, Feb 15, 2021 at 5:10 PM Yuan Mei <yuanmei.w...@gmail.com> wrote: > > > Hey devs, > > > > I'm very glad to announce that all known blocking issues for > release-1.12.2 > > have been resolved. > > > > release-1.12.2 will freeze at: > > commit 1f8be1fd7b2b37a124e4d2b8080d08e259bdf095 > > > > Roman and I are about to prepare the first release candidate and many > > thanks to Roman for agreeing to do the release together with me! > > > > We will start a separate voting thread as soon as RC1 is created. > > > > Best, > > > > Yuan > > > > On Thu, Feb 11, 2021 at 2:11 AM Matthias Pohl <matth...@ververica.com> > > wrote: > > > > > I created FLINK-21358 [1] (and a PR [2] for it) which we might want to > > > include in 1.12.2 as well. > > > > > > Best, > > > Matthias > > > > > > [1] https://issues.apache.org/jira/browse/FLINK-21358 > > > [2] https://github.com/apache/flink/pull/14920 > > > > > > On Tue, Feb 9, 2021 at 1:19 PM Yuan Mei <yuanmei.w...@gmail.com> > wrote: > > > > > >> Thanks very much for your replies! > > >> > > >> I've been reaching out to the owners of the issues/blockers mentioned > > >> above. By now, we have > > >> > > >> Blocker Issues: > > >> > > >> - > > >> > > >> https://issues.apache.org/jira/browse/FLINK-21013: fixed > > >> - > > >> > > >> https://issues.apache.org/jira/browse/FLINK-21030: estimate to > > finish > > >> by the end of this week, but should not be a release blocker > > >> > > >> Best to Include: > > >> > > >> - > > >> > > >> https://issues.apache.org/jira/browse/FLINK-20417: fixed > > >> - > > >> > > >> https://issues.apache.org/jira/browse/FLINK-20663: estimate to > > finish > > >> by the end of this week, but should not be a release blocker > > >> - > > >> > > >> https://github.com/apache/flink/pull/14848: under review > > >> > > >> > > >> Hence, let's target *a feature freeze on Feb. 15, next Monday*! > > >> > > >> If there is any concern on anything, please feel free to contact me. > > >> > > >> Best > > >> Yuan > > >> > > >> > > >> On Tue, Feb 9, 2021 at 4:38 AM Matthias Pohl <matth...@ververica.com> > > >> wrote: > > >> > > >>> Fabian and I were investigating strange behavior with > > stop-with-savepoint > > >>> not terminating when using the new fromSource to add a source to a > job > > >>> definition. I created FLINK-21323 [1] to cover the issue. This might > > not > > >>> be > > >>> a blocker for 1.12.2 since this bug would have been already around > > since > > >>> 1.11, if I'm not mistaken? I wanted to bring this to your attention, > > >>> anyway. It would be good if someone more familiar with this part of > the > > >>> source code could verify our findings and confirm the severity of the > > >>> issue. > > >>> > > >>> Best, > > >>> Matthias > > >>> > > >>> [1] https://issues.apache.org/jira/browse/FLINK-21323 > > >>> > > >>> On Mon, Feb 8, 2021 at 7:25 PM Thomas Weise <t...@apache.org> wrote: > > >>> > > >>> > +1 for the 1.12.2 release > > >>> > > > >>> > On Mon, Feb 8, 2021 at 3:20 AM Matthias Pohl < > matth...@ververica.com > > > > > >>> > wrote: > > >>> > > > >>> > > Thanks Yuan for driving 1.12.2. > > >>> > > +1 for releasing 1.12.2 > > >>> > > > > >>> > > One comment about FLINK-21030 [1]: I hope to fix it this week. > But > > >>> there > > >>> > > are still some uncertainties. The underlying problem is older > than > > >>> 1.12. > > >>> > > Hence, the suggestion is to not block the 1.12.2 release because > of > > >>> > > FLINK-21030 [1]. I will leave it as a blocker issue, though, to > > >>> underline > > >>> > > that it should be fixed for 1.13. > > >>> > > > > >>> > > Best, > > >>> > > Matthias > > >>> > > > > >>> > > [1] https://issues.apache.org/jira/browse/FLINK-21030 > > >>> > > > > >>> > > On Sun, Feb 7, 2021 at 4:10 AM Xintong Song < > tonysong...@gmail.com > > > > > >>> > wrote: > > >>> > > > > >>> > > > Thanks Yuan, > > >>> > > > > > >>> > > > +1 for releasing 1.12.2 and Yuan as the release manager. > > >>> > > > > > >>> > > > Thank you~ > > >>> > > > > > >>> > > > Xintong Song > > >>> > > > > > >>> > > > > > >>> > > > > > >>> > > > On Sat, Feb 6, 2021 at 3:41 PM Yu Li <car...@gmail.com> wrote: > > >>> > > > > > >>> > > > > +1 for releasing 1.12.2, and thanks for volunteering to be > our > > >>> > release > > >>> > > > > manager Yuan. > > >>> > > > > > > >>> > > > > Besides the mentioned issues, I could see two more blockers > > with > > >>> > 1.12.2 > > >>> > > > as > > >>> > > > > fix version [1] and need some tracking: > > >>> > > > > * FLINK-21013 < > > https://issues.apache.org/jira/browse/FLINK-21013 > > >>> > > > >>> > > Blink > > >>> > > > > planner does not ingest timestamp into StreamRecord > > >>> > > > > * FLINK- 21030 <http://Broken job restart for job with > > disjoint > > >>> > graph> > > >>> > > > > Broken > > >>> > > > > job restart for job with disjoint graph > > >>> > > > > > > >>> > > > > Best Regards, > > >>> > > > > Yu > > >>> > > > > > > >>> > > > > [1] https://s.apache.org/flink-1.12.2-blockers > > >>> > > > > > > >>> > > > > > > >>> > > > > On Sat, 6 Feb 2021 at 08:57, Kurt Young <ykt...@gmail.com> > > >>> wrote: > > >>> > > > > > > >>> > > > > > Thanks for being our release manager Yuan. > > >>> > > > > > > > >>> > > > > > We found a out of memory issue [1] which will affect most > > batch > > >>> > jobs > > >>> > > > > thus I > > >>> > > > > > think > > >>> > > > > > it would be great if we can include this fix in 1.12.2. > > >>> > > > > > > > >>> > > > > > [1] https://issues.apache.org/jira/browse/FLINK-20663 > > >>> > > > > > > > >>> > > > > > Best, > > >>> > > > > > Kurt > > >>> > > > > > > > >>> > > > > > > > >>> > > > > > On Sat, Feb 6, 2021 at 12:36 AM Till Rohrmann < > > >>> > trohrm...@apache.org> > > >>> > > > > > wrote: > > >>> > > > > > > > >>> > > > > > > Thanks for volunteering for being our release manager > Yuan > > >>> :-) > > >>> > > > > > > > > >>> > > > > > > +1 for a timely bug fix release. > > >>> > > > > > > > > >>> > > > > > > I will try to review the PR for FLINK- 20417 [1] which > is a > > >>> good > > >>> > > fix > > >>> > > > to > > >>> > > > > > > include in the next bug fix release. We don't have to > block > > >>> the > > >>> > > > release > > >>> > > > > > on > > >>> > > > > > > this fix though. > > >>> > > > > > > > > >>> > > > > > > [1] https://issues.apache.org/jira/browse/FLINK-20417 > > >>> > > > > > > > > >>> > > > > > > Cheers, > > >>> > > > > > > Till > > >>> > > > > > > > > >>> > > > > > > On Fri, Feb 5, 2021 at 5:12 PM Piotr Nowojski < > > >>> > > pnowoj...@apache.org> > > >>> > > > > > > wrote: > > >>> > > > > > > > > >>> > > > > > > > Hi, > > >>> > > > > > > > > > >>> > > > > > > > Thanks Yuan for bringing up this topic. > > >>> > > > > > > > > > >>> > > > > > > > +1 for the quick 1.12.2 release. > > >>> > > > > > > > > > >>> > > > > > > > As Yuan mentioned, me and Roman can help whenever > > committer > > >>> > > rights > > >>> > > > > will > > >>> > > > > > > be > > >>> > > > > > > > required. > > >>> > > > > > > > > > >>> > > > > > > > > I am a Firefox user and I just fixed a long lasting > bug > > >>> > > > > > > > https://github.com/apache/flink/pull/14848 , wish this > > >>> would > > >>> > be > > >>> > > > > merged > > >>> > > > > > > in > > >>> > > > > > > > this release. > > >>> > > > > > > > > > >>> > > > > > > > I will push to speed up review of your PR. Let's try to > > >>> merge > > >>> > it > > >>> > > > > before > > >>> > > > > > > > 1.12.2, but at the same time I wouldn't block the > release > > >>> on > > >>> > this > > >>> > > > > bug. > > >>> > > > > > > > > > >>> > > > > > > > Best, > > >>> > > > > > > > Piotrek > > >>> > > > > > > > > > >>> > > > > > > > pt., 5 lut 2021 o 12:12 郁蓝 <happyhacker...@foxmail.com > > > > >>> > > > napisał(a): > > >>> > > > > > > > > > >>> > > > > > > > > Hi Yuan, > > >>> > > > > > > > > > > >>> > > > > > > > > > > >>> > > > > > > > > I am a Firefox user and I just fixed a long lasting > bug > > >>> > > > > > > > > https://github.com/apache/flink/pull/14848 , wish > this > > >>> would > > >>> > > be > > >>> > > > > > merged > > >>> > > > > > > > in > > >>> > > > > > > > > this release. > > >>> > > > > > > > > > > >>> > > > > > > > > > > >>> > > > > > > > > Best wishes > > >>> > > > > > > > > > > >>> > > > > > > > > > > >>> > > > > > > > > > > >>> > > > > > > > > ------------------ 原始邮件 ------------------ > > >>> > > > > > > > > 发件人: > > >>> > > > > > > > > > "dev" > > >>> > > > > > > > > > > >>> > > < > > >>> > > > > > > > > yuanmei.w...@gmail.com>; > > >>> > > > > > > > > 发送时间: 2021年2月5日(星期五) 晚上6:36 > > >>> > > > > > > > > 收件人: "dev"<dev@flink.apache.org>; > > >>> > > > > > > > > > > >>> > > > > > > > > 主题: [DISCUSS] Releasing Apache Flink 1.12.2 > > >>> > > > > > > > > > > >>> > > > > > > > > > > >>> > > > > > > > > > > >>> > > > > > > > > Hey devs, > > >>> > > > > > > > > > > >>> > > > > > > > > One of the major issues that have not been resolved > in > > >>> Apache > > >>> > > > Flink > > >>> > > > > > > > 1.12.1 > > >>> > > > > > > > > is "unaligned > > >>> > > > > > > > > checkpoint recovery may lead to corrupted data > > >>> stream"[1]. > > >>> > > Since > > >>> > > > > the > > >>> > > > > > > > > problem is now fixed and > > >>> > > > > > > > > it is critical to the users, I would like to kick > off a > > >>> > > > discussion > > >>> > > > > on > > >>> > > > > > > > > releasing Flink 1.12.2 that > > >>> > > > > > > > > includes unaligned checkpoint fixes. > > >>> > > > > > > > > > > >>> > > > > > > > > I would like to volunteer myself for managing this > > >>> release. > > >>> > > But I > > >>> > > > > > > noticed > > >>> > > > > > > > > that some of the release > > >>> > > > > > > > > steps may require committer authorities. Luckily, > Piotr > > >>> and > > >>> > > Roman > > >>> > > > > are > > >>> > > > > > > > very > > >>> > > > > > > > > kind to provide help > > >>> > > > > > > > > on such steps. > > >>> > > > > > > > > > > >>> > > > > > > > > Apart from the unaligned checkpoint issue, please let > > us > > >>> know > > >>> > > in > > >>> > > > > this > > >>> > > > > > > > > thread if there are any > > >>> > > > > > > > > other fixes that we should try to include in this > > >>> version. > > >>> > I'll > > >>> > > > try > > >>> > > > > > to > > >>> > > > > > > > > communicate with the issue > > >>> > > > > > > > > owners and come up with a time estimation next week. > > >>> > > > > > > > > > > >>> > > > > > > > > [1] > https://issues.apache.org/jira/browse/FLINK-20654 > > >>> > > > > > > > > > > >>> > > > > > > > > Best > > >>> > > > > > > > > Yuan > > >>> > > > > > > > > > >>> > > > > > > > > >>> > > > > > > > >>> > > > > > > >>> > > > > >>> > > > >> > > >> > > >
