The changes need to also go into branches/2.1, because right now we have different/duplicate versions of some depends included in Geronimo 2.1.x and 2.2, due to the gshell-embeddable jarfile, which was created using the shade-maven-plugin and no one noticed the mismatched depends and the fact that Geronimo is actually including additional plexus and gshell jars that are not visible in our repository, due to shade extracting them and repackaging them into this uber gshell-embeddable jar.....
I'm for fixing the transitive depend mechanism in car-maven-plugin, as long as it correctly handles different versions between the server and other projects, with the server/pom.xml specified versions always winning.
I'm against the continued usage of the gshell-embeddable jar, as it hides the fact that we are including other depends in our server assemblies and will just likely cause more version conflicts and duplicate depends in the future. Maybe if you get the car-maven-plugin updated for transitive depends and mismatched versions, then we can just create a new gshell-framework pom that lets gshell tell us and the car-maven-plugin which depends to pull in....
-Donald David Jencks wrote:
I talked with jason a bit on irc and we're doing an experiment with optionally including transitive dependencies using the car-maven-plugin. Hopefully this will work and avoid the duplication jason is leery of. Please don't commit duplication until we find out if this works or not.AFAICT this isn't a bug fix but rather new development so I'm unclear about why you are thinking of including this in 2.1.2?thanks david jencks On May 13, 2008, at 11:32 AM, Donald Woods wrote:I started with your new framework/configs/gshell-* code, updated gshell-framework to include all the individual depends so we don't need gshell-embeddable, updated server/pom.xml with the new depends and updated boilerplate with the new gshell-geronimo car depend and it looks promising. I'm still exercising some of the gsh commands, but so far help, geronimo/start-server, deploy/connect and geronimo/stop-server are working....If all looks well after a few more tests, I'll commit the changes into trunk for everyone to review before we spend the time pulling it into 2.1.2.-Donald Jason Dillon wrote:On May 13, 2008, at 1:14 AM, David Jencks wrote:So including the dependencies you need for gshell in the boilerplate's pom would get them into the geronimo repo. As I said transitive dependencies don't result in inclusion at the moment for rather good reasons. I don't know what the <include> tag would do but it's probably worth investigating.What <include> tag are you talking about?I guess I'm gonna try to make plugins for the gshell dependencies, these 3:gshell-framework - just the core bits required to make gshell workgshell-geronimo - our additional commands to work with the server + their depsgshell-remote - the remote/whisper commandsI must say I'm really quite frustrated at the lack of transitive dependency support here. As this means that alot of the dependencyManagement configuration which is already in the GShell poms need to be duplicated into the Geronimo poms, making version management even more of a nightmare.:-(Well, I started to add these cars to framework/configs, but I must admit I really am clueless for how this stuff works now.:-( --jason
smime.p7s
Description: S/MIME Cryptographic Signature
