phet commented on a change in pull request #3382:
URL: https://github.com/apache/gobblin/pull/3382#discussion_r702184911
##########
File path:
gobblin-restli/gobblin-flow-config-service/gobblin-flow-config-service-server/src/main/java/org/apache/gobblin/service/FlowExecutionResourceHandler.java
##########
@@ -36,6 +36,14 @@
*/
public List<FlowExecution> getLatestFlowExecution(PagingContext context,
FlowId flowId, Integer count, String tag, String executionStatus);
+ /**
+ * Get latest {@link FlowExecution} for every flow in `flowGroup`
+ *
+ * NOTE: `executionStatus` param not provided yet, without justifying use
case, due to complexity of interaction with `count`
+ * and resulting efficiency concern of performing across many flows sharing
the single named group.
+ */
+ public List<FlowExecution> getLatestFlowGroupExecutions(PagingContext
context, String flowGroup, Integer count, String tag);
Review comment:
this count is semantically the maximum number of executions for each
flow found within the group, not the total number of `FlowExecution`s to
return. that said, following the lead of `getLatestFlowExecution` (directly
above), which also ignores it, I never inspect or utilize the `PagingContext`.
I presumed it to be a mandated param, but if it would be legal to omit it, that
would be a clearer statement of intent (to ignore). do you know if I could?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
