phet commented on a change in pull request #3382:
URL: https://github.com/apache/gobblin/pull/3382#discussion_r705563814
##########
File path:
gobblin-restli/gobblin-flow-config-service/gobblin-flow-config-service-server/src/main/java/org/apache/gobblin/service/FlowExecutionResource.java
##########
@@ -63,6 +63,12 @@ public FlowExecution get(ComplexResourceKey<FlowStatusId,
EmptyRecord> key) {
return this.flowExecutionResourceHandler.getLatestFlowExecution(context,
flowId, count, tag, executionStatus);
}
+ @Finder("latestFlowGroupExecutions")
+ public List<FlowExecution> getLatestFlowGroupExecutions(@Context
PagingContext context, @QueryParam("flowGroup") String flowGroup,
Review comment:
that change would break b/w compatibility for existing clients. also,
the existing name is misleading as `latestFlowExecution`, if it would return
multiple executions across all flows of the group.
plus, after my latest update to this PR, at alex's suggestion, naming of
corresponding params has diverged across the two (i.e. `count` and
`countPerFlow`).
do you have a particular concern about adding a new finder?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
