phet commented on a change in pull request #3382:
URL: https://github.com/apache/gobblin/pull/3382#discussion_r705538389
##########
File path:
gobblin-restli/gobblin-flow-config-service/gobblin-flow-config-service-server/src/main/java/org/apache/gobblin/service/FlowExecutionResource.java
##########
@@ -63,6 +63,12 @@ public FlowExecution get(ComplexResourceKey<FlowStatusId,
EmptyRecord> key) {
return this.flowExecutionResourceHandler.getLatestFlowExecution(context,
flowId, count, tag, executionStatus);
}
+ @Finder("latestFlowGroupExecutions")
+ public List<FlowExecution> getLatestFlowGroupExecutions(@Context
PagingContext context, @QueryParam("flowGroup") String flowGroup,
Review comment:
I wanted to differentiate them semantically with a separate name for
each finder. the other issue with making the flow name optional on the
existing finder is that it is not top-level, but a component of the `flowId`
compound param.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
