arjun4084346 commented on a change in pull request #3382:
URL: https://github.com/apache/gobblin/pull/3382#discussion_r704950206



##########
File path: 
gobblin-restli/gobblin-flow-config-service/gobblin-flow-config-service-server/src/main/java/org/apache/gobblin/service/FlowExecutionResource.java
##########
@@ -63,6 +63,12 @@ public FlowExecution get(ComplexResourceKey<FlowStatusId, 
EmptyRecord> key) {
     return this.flowExecutionResourceHandler.getLatestFlowExecution(context, 
flowId, count, tag, executionStatus);
   }
 
+  @Finder("latestFlowGroupExecutions")
+  public List<FlowExecution> getLatestFlowGroupExecutions(@Context 
PagingContext context, @QueryParam("flowGroup") String flowGroup,

Review comment:
       Should we rather just add an @Optional @QueryParam to the existing 
getLatestFlowExecution finder method?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to