aplex commented on a change in pull request #3382:
URL: https://github.com/apache/gobblin/pull/3382#discussion_r703811318
##########
File path:
gobblin-restli/gobblin-flow-config-service/gobblin-flow-config-service-server/src/main/java/org/apache/gobblin/service/FlowExecutionResourceHandler.java
##########
@@ -36,6 +36,14 @@
*/
public List<FlowExecution> getLatestFlowExecution(PagingContext context,
FlowId flowId, Integer count, String tag, String executionStatus);
+ /**
+ * Get latest {@link FlowExecution} for every flow in `flowGroup`
+ *
+ * NOTE: `executionStatus` param not provided yet, without justifying use
case, due to complexity of interaction with `count`
+ * and resulting efficiency concern of performing across many flows sharing
the single named group.
+ */
+ public List<FlowExecution> getLatestFlowGroupExecutions(PagingContext
context, String flowGroup, Integer count, String tag);
Review comment:
How many results can we return in this response? There could be 100k
flows, and if we return all of them in one response, it might take too long to
generate it and the request will time out.
If this count is not about the number of flowExecutions, then can we name it
differently to make this more clear? Like "maxExecutionsPerFlow" or something
like that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
