phet commented on a change in pull request #3382:
URL: https://github.com/apache/gobblin/pull/3382#discussion_r705568923
##########
File path:
gobblin-restli/gobblin-flow-config-service/gobblin-flow-config-service-server/src/main/java/org/apache/gobblin/service/FlowExecutionResource.java
##########
@@ -63,6 +63,12 @@ public FlowExecution get(ComplexResourceKey<FlowStatusId,
EmptyRecord> key) {
return this.flowExecutionResourceHandler.getLatestFlowExecution(context,
flowId, count, tag, executionStatus);
}
+ @Finder("latestFlowGroupExecutions")
+ public List<FlowExecution> getLatestFlowGroupExecutions(@Context
PagingContext context, @QueryParam("flowGroup") String flowGroup,
+ @Optional @QueryParam("countPerFlow") Integer countPerFlow, @Optional
@QueryParam("tag") String tag) {
Review comment:
I punted on that... and was unsure with all the layering where to put
javadoc to that effect. finding more on the `FlowExecutionResourceHandler`
than here, I added this note in that location -
```
* NOTE: `executionStatus` param not provided yet, without justifying use
case, due to complexity of interaction with `count`
* and resulting efficiency concern of performing across many flows
sharing the single named group.
```
so basically I was waiting for a use case. I do note that the
`executionStatus` on `latestFlowExecution` remains unexercised by our existing
CLI client, so I definitely didn't want to pursue replicating something that
itself may see little usage.
do note that if we decide to add this param here later, it should preserve
b/w compatibility on this finder.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
