[
https://issues.apache.org/jira/browse/GOBBLIN-2168?focusedWorklogId=940833&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-940833
]
ASF GitHub Bot logged work on GOBBLIN-2168:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 30/Oct/24 04:24
Start Date: 30/Oct/24 04:24
Worklog Time Spent: 10m
Work Description: linweihs opened a new pull request, #4070:
URL: https://github.com/apache/gobblin/pull/4070
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I
have checked off all the steps below!
### JIRA
- [x] My PR addresses the following
[GOBBLIN-2168](https://issues.apache.org/jira/browse/GOBBLIN-2168)
### Description
- [x] Here are some details about my PR, including screenshots (if
applicable):
In existing trash cleaner, the comparison between snapshotTime and the
current time is NOT done in the same time zone, this leads to longer hard
deletion time due to time zone difference.
the fix ensure that the comparison between snapshotTime and the current time
is done in the same time zone
### Tests
- [x] My PR adds the following unit tests :
Implement a unit test class
`[TimeBasedSnapshotCleanupPolicyTest.java](https://github.com/apache/gobblin/compare/master...linweihs:incubator-gobblin:welin/trash?expand=1#diff-59e30e386f99115a2511854af4f01812ea1cf832430c696bb48182af91713f77)`
ensuring the comparison are asserted expectedly.
### Commits
- [ ] My commits all reference JIRA issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
Issue Time Tracking
-------------------
Worklog Id: (was: 940833)
Remaining Estimate: 0h
Time Spent: 10m
> Use isBefore(nowInUTC) to compare snapshots with the current time in UTC.
> -------------------------------------------------------------------------
>
> Key: GOBBLIN-2168
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2168
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Wei-Hsiang Lin
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> In existing trash cleaner, the comparison between snapshotTime and the
> current time is NOT done in the same time zone, this leads to longer hard
> deletion time due to time zone difference.
> the fix ensure that the comparison between snapshotTime and the current time
> is done in the same time zone
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
