[
https://issues.apache.org/jira/browse/GOBBLIN-2168?focusedWorklogId=943635&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-943635
]
ASF GitHub Bot logged work on GOBBLIN-2168:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 13/Nov/24 19:00
Start Date: 13/Nov/24 19:00
Worklog Time Spent: 10m
Work Description: codecov-commenter commented on PR #4070:
URL: https://github.com/apache/gobblin/pull/4070#issuecomment-2474484944
##
[Codecov](https://app.codecov.io/gh/apache/gobblin/pull/4070?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
Report
All modified and coverable lines are covered by tests :white_check_mark:
> Project coverage is 41.30%. Comparing base
[(`45ad13e`)](https://app.codecov.io/gh/apache/gobblin/commit/45ad13e07ebe212002b279132e1fa4d121a9294f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
to head
[(`3ead802`)](https://app.codecov.io/gh/apache/gobblin/commit/3ead802b272f41ebf43964117155881b8a42cc3b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 22 commits behind head on master.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #4070 +/- ##
============================================
- Coverage 45.12% 41.30% -3.82%
+ Complexity 3199 2233 -966
============================================
Files 705 485 -220
Lines 26949 20599 -6350
Branches 2680 2382 -298
============================================
- Hits 12160 8508 -3652
+ Misses 13781 11190 -2591
+ Partials 1008 901 -107
```
</details>
[:umbrella: View full report in Codecov by
Sentry](https://app.codecov.io/gh/apache/gobblin/pull/4070?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it
here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
Issue Time Tracking
-------------------
Worklog Id: (was: 943635)
Time Spent: 1h 20m (was: 1h 10m)
> Use isBefore(nowInUTC) to compare snapshots with the current time in UTC.
> -------------------------------------------------------------------------
>
> Key: GOBBLIN-2168
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2168
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Wei-Hsiang Lin
> Priority: Major
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> In existing trash cleaner, the comparison between snapshotTime and the
> current time is NOT done in the same time zone, this leads to longer hard
> deletion time due to time zone difference.
> the fix ensure that the comparison between snapshotTime and the current time
> is done in the same time zone
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
