[
https://issues.apache.org/jira/browse/GOBBLIN-2168?focusedWorklogId=942911&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-942911
]
ASF GitHub Bot logged work on GOBBLIN-2168:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 09/Nov/24 08:00
Start Date: 09/Nov/24 08:00
Worklog Time Spent: 10m
Work Description: linweihs commented on code in PR #4070:
URL: https://github.com/apache/gobblin/pull/4070#discussion_r1835312249
##########
gobblin-data-management/src/main/java/org/apache/gobblin/data/management/trash/TimeBasedSnapshotCleanupPolicy.java:
##########
@@ -41,6 +42,7 @@ public TimeBasedSnapshotCleanupPolicy(Properties props) {
@Override
public boolean shouldDeleteSnapshot(FileStatus snapshot, Trash trash) {
DateTime snapshotTime =
Trash.TRASH_SNAPSHOT_NAME_FORMATTER.parseDateTime(snapshot.getPath().getName());
- return snapshotTime.plusMinutes(this.retentionMinutes).isBeforeNow();
+ // To ensure that the comparison between snapshotTime and the current time
is done in the same time zone
+ return
snapshotTime.plusMinutes(this.retentionMinutes).isBefore(DateTime.now(DateTimeZone.UTC));
Review Comment:
thanks for the suggestion, this is indeed much cleaner and more reasonable
Issue Time Tracking
-------------------
Worklog Id: (was: 942911)
Time Spent: 50m (was: 40m)
> Use isBefore(nowInUTC) to compare snapshots with the current time in UTC.
> -------------------------------------------------------------------------
>
> Key: GOBBLIN-2168
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2168
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Wei-Hsiang Lin
> Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
> In existing trash cleaner, the comparison between snapshotTime and the
> current time is NOT done in the same time zone, this leads to longer hard
> deletion time due to time zone difference.
> the fix ensure that the comparison between snapshotTime and the current time
> is done in the same time zone
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
