[
https://issues.apache.org/jira/browse/GOBBLIN-2168?focusedWorklogId=944706&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-944706
]
ASF GitHub Bot logged work on GOBBLIN-2168:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 20/Nov/24 22:48
Start Date: 20/Nov/24 22:48
Worklog Time Spent: 10m
Work Description: linweihs commented on PR #4070:
URL: https://github.com/apache/gobblin/pull/4070#issuecomment-2489691544
**Updated 2024/11/20:**
I found out a bug internally where theres discrepancy between
java.utils.Properties and Azkaban prop object during props passing, thats
results in parent config is not pass all the way down to
`TimeBasedSnapshotCleanupPolicy.java` in runtime.
I've reverted TimeBasedSnapshotCleanupPolicy to original code, and tested
are expected. the However, i've added unit tests
`TimeBasedSnapshotCleanupPolicyTest` ensuring the test coverage.
During investigation, also found a bug (in Trash.java) where Trash use
`props.contains(TRASH_CLASS_KEY))` which leads to unexpected evalation whereas
the intention is to `props.containsKey(TRASH_CLASS_KEY))`
Issue Time Tracking
-------------------
Worklog Id: (was: 944706)
Time Spent: 1h 50m (was: 1h 40m)
> Use isBefore(nowInUTC) to compare snapshots with the current time in UTC.
> -------------------------------------------------------------------------
>
> Key: GOBBLIN-2168
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2168
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Wei-Hsiang Lin
> Priority: Major
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> In existing trash cleaner, the comparison between snapshotTime and the
> current time is NOT done in the same time zone, this leads to longer hard
> deletion time due to time zone difference.
> the fix ensure that the comparison between snapshotTime and the current time
> is done in the same time zone
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
