[
https://issues.apache.org/jira/browse/GOBBLIN-2168?focusedWorklogId=941221&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-941221
]
ASF GitHub Bot logged work on GOBBLIN-2168:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 31/Oct/24 21:20
Start Date: 31/Oct/24 21:20
Worklog Time Spent: 10m
Work Description: Will-Lo commented on code in PR #4070:
URL: https://github.com/apache/gobblin/pull/4070#discussion_r1825175801
##########
gobblin-data-management/src/main/java/org/apache/gobblin/data/management/trash/TimeBasedSnapshotCleanupPolicy.java:
##########
@@ -41,6 +42,7 @@ public TimeBasedSnapshotCleanupPolicy(Properties props) {
@Override
public boolean shouldDeleteSnapshot(FileStatus snapshot, Trash trash) {
DateTime snapshotTime =
Trash.TRASH_SNAPSHOT_NAME_FORMATTER.parseDateTime(snapshot.getPath().getName());
- return snapshotTime.plusMinutes(this.retentionMinutes).isBeforeNow();
+ // To ensure that the comparison between snapshotTime and the current time
is done in the same time zone
+ return
snapshotTime.plusMinutes(this.retentionMinutes).isBefore(DateTime.now(DateTimeZone.UTC));
Review Comment:
I think it would be more extensible if we had something like the following:
```
public static final String RETENTION_SNAPSHOT_TIMEZONE =
"gobblin.trash.snapshot.retention.timezone"
Timezone retentionSnapshotTimezone;
...
this.retentionSnapshotTImezone =
props.containsKey(RETENTION_SNAPSHOT_TIMEZONE) ?
Timezone.getTimeZone(props.getProperty(RETENTION_SNAPSHOT_TIMEZONE)) :
DateTimeZone.getDefault();
...
return
snapshotTime.plusMinutes(this.retentionMinutes).isBefore(DateTime.now(this.retentionSnapshotTimezone));
```
This allows the retention snapshot be more configurable in the long term and
more explciit what the behavior is.
Issue Time Tracking
-------------------
Worklog Id: (was: 941221)
Time Spent: 40m (was: 0.5h)
> Use isBefore(nowInUTC) to compare snapshots with the current time in UTC.
> -------------------------------------------------------------------------
>
> Key: GOBBLIN-2168
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2168
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Wei-Hsiang Lin
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> In existing trash cleaner, the comparison between snapshotTime and the
> current time is NOT done in the same time zone, this leads to longer hard
> deletion time due to time zone difference.
> the fix ensure that the comparison between snapshotTime and the current time
> is done in the same time zone
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
