necouchman commented on code in PR #1087:
URL: https://github.com/apache/guacamole-client/pull/1087#discussion_r2112700911
##########
guacamole-ext/src/main/java/org/apache/guacamole/properties/GuacamoleProperty.java:
##########
@@ -39,7 +39,7 @@ public interface GuacamoleProperty<Type> {
* input string which match this pattern will not be included in the parsed
* result.
*/
- static final Pattern DELIMITER_PATTERN = Pattern.compile(";\\s*");
+ static final Pattern DELIMITER_PATTERN = Pattern.compile("[;,]\\s*");
Review Comment:
```
json-trusted-networks
ldap-group-name-attribute
ldap-user-attributes
ldap-username-attribute
openid-attributes-claim-type
quickconnect-allowed-parameters
quickconnect-denied-parameters
ssl-subject-username-attribute
```
I think all of these will be good with comma-separated values, or perhaps
both comma and semicolon-separated values. I suspect the URIs along with any of
the ones that take a LDAP DNs can use semicolons.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
