mike-jumper commented on code in PR #1087:
URL: https://github.com/apache/guacamole-client/pull/1087#discussion_r2112812431
##########
guacamole-ext/src/main/java/org/apache/guacamole/properties/GuacamoleProperty.java:
##########
@@ -39,7 +39,7 @@ public interface GuacamoleProperty<Type> {
* input string which match this pattern will not be included in the parsed
* result.
*/
- static final Pattern DELIMITER_PATTERN = Pattern.compile(";\\s*");
+ static final Pattern DELIMITER_PATTERN = Pattern.compile("[;,]\\s*");
Review Comment:
Nope, I don't think you're missing anything. Rechecking things myself:
* I don't see any usage of `getPropertyCollection()` or
`getRequiredPropertyCollection()` within guacamole-client that wouldn't work
with comma-delimited values.
* Nothing is using `URIGuacamoleProperty` _and_ retrieving values with
collections.
Also, since whitespace characters cannot legally be included in any URI,
that's probably a better choice for the `URIGuacamoleProperty` separator than a
semicolon (which is legal in URIs).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
