mike-jumper commented on code in PR #1087:
URL: https://github.com/apache/guacamole-client/pull/1087#discussion_r2114866613
##########
guacamole-ext/src/main/java/org/apache/guacamole/properties/FileGuacamoleProperty.java:
##########
@@ -23,13 +23,22 @@
import java.util.ArrayList;
import java.util.Arrays;
import java.util.List;
+import java.util.regex.Pattern;
import org.apache.guacamole.GuacamoleException;
/**
* A GuacamoleProperty whose value is a filename.
*/
public abstract class FileGuacamoleProperty implements GuacamoleProperty<File>
{
+ /**
+ * A pattern which matches against the delimiters between values. This is
+ * currently simply a semicolon and any following whitespace. Parts of the
Review Comment:
> ... This is currently simply a semicolon and any following whitespace ...
This needs to be updated to include the comma among the characters used as
delimiters (same for other comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
