necouchman commented on code in PR #1087:
URL: https://github.com/apache/guacamole-client/pull/1087#discussion_r2112757061
##########
guacamole-ext/src/main/java/org/apache/guacamole/properties/GuacamoleProperty.java:
##########
@@ -39,7 +39,7 @@ public interface GuacamoleProperty<Type> {
* input string which match this pattern will not be included in the parsed
* result.
*/
- static final Pattern DELIMITER_PATTERN = Pattern.compile(";\\s*");
+ static final Pattern DELIMITER_PATTERN = Pattern.compile("[;,]\\s*");
Review Comment:
Looking further at this, it seems like `URIGuacamoleProperty` is really the
only base one of those classes that needs any adjusting. Most of the
LDAP-related ones that are used for DNs don't really support multi-value
delimiting, they seem to just use the default behavior of providing a
`singletonList()` for the specified value.
Anything I'm missing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
